Add API endpoint for request type key of submission template #5605
Open
Add API endpoint for request type key of submission template #5605
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5605 +/- ##
===========================================
- Coverage 87.25% 87.21% -0.04%
===========================================
Files 1460 1460
Lines 32966 33030 +64
Branches 3465 3479 +14
===========================================
+ Hits 28764 28808 +44
- Misses 4181 4201 +20
Partials 21 21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
StephenHulme
requested changes
Mar 12, 2026
Contributor
StephenHulme
left a comment
There was a problem hiding this comment.
Looks good, minor comment
Comment on lines
+46
to
+49
| ### | ||
| # Filters | ||
| ### | ||
| # Allow filtering by UUID |
Contributor
There was a problem hiding this comment.
Would you please add a more detailed docstring? We try keep out API documentation top-notch since it is used by other developers and applications.
SampleMetadataResource has a nice example:
# @!method filter_sample_id(value)
# Filters sample metadata by `sample_id`, allowing users to retrieve metadata for a specific sample.
#
# @example Filtering by sample_id
# GET /api/v2/sample_metadata?filter[sample_id]=456
#
# @param value [String] The sample ID to filter by.
# @return [SampleMetadataResource] The metadata records matching the given sample ID.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
Changes proposed in this pull request
Add request type key to submission template API, also allow filter by template uuid
Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main]- Check story numbers included
- Check for debug code
- Check version