Skip to content

Add API endpoint for request type key of submission template #5605

Open
wendyyang wants to merge 6 commits intodevelopfrom
Y26-004--lcm-triomics-add_RNAseq_template
Open

Add API endpoint for request type key of submission template #5605
wendyyang wants to merge 6 commits intodevelopfrom
Y26-004--lcm-triomics-add_RNAseq_template

Conversation

@wendyyang
Copy link
Contributor

@wendyyang wendyyang commented Mar 11, 2026

Closes #

Changes proposed in this pull request

Add request type key to submission template API, also allow filter by template uuid

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

@wendyyang wendyyang marked this pull request as ready for review March 11, 2026 20:49
@codecov
Copy link

codecov bot commented Mar 11, 2026

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 87.21%. Comparing base (f5ed910) to head (b972d26).
⚠️ Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
...p/resources/api/v2/submission_template_resource.rb 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5605      +/-   ##
===========================================
- Coverage    87.25%   87.21%   -0.04%     
===========================================
  Files         1460     1460              
  Lines        32966    33030      +64     
  Branches      3465     3479      +14     
===========================================
+ Hits         28764    28808      +44     
- Misses        4181     4201      +20     
  Partials        21       21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@StephenHulme StephenHulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, minor comment

Comment on lines +46 to +49
###
# Filters
###
# Allow filtering by UUID
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you please add a more detailed docstring? We try keep out API documentation top-notch since it is used by other developers and applications.

SampleMetadataResource has a nice example:

      # @!method filter_sample_id(value)
      #   Filters sample metadata by `sample_id`, allowing users to retrieve metadata for a specific sample.
      #
      #   @example Filtering by sample_id
      #     GET /api/v2/sample_metadata?filter[sample_id]=456
      #
      #   @param value [String] The sample ID to filter by.
      #   @return [SampleMetadataResource] The metadata records matching the given sample ID.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants