disable the button for the same request type only#2731
disable the button for the same request type only#2731wendyyang wants to merge 7 commits intoTriomic_Epicfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## Triomic_Epic #2731 +/- ##
================================================
- Coverage 84.91% 84.90% -0.02%
================================================
Files 502 502
Lines 20615 20619 +4
Branches 377 377
================================================
+ Hits 17506 17507 +1
- Misses 3106 3109 +3
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| def active_request_types | ||
| wells.flat_map(&:active_requests) | ||
| .map(&:request_type_key) | ||
| .uniq |
There was a problem hiding this comment.
Again, this could use requests_as_source rather than active_requests, since we're on the first plate in the pipeline here, expecting these requests to originate in this plate.
There was a problem hiding this comment.
requests_as_source is private method, can't use
| { | ||
| 'EM-seq (+ WGS) Branch - Automated Submission' => 'limber_lcm_triomics_emseq', | ||
| 'RNA-Seq Branch - Automated Submission' => 'limber_lcm_triomics_rnaseq' | ||
| } |
There was a problem hiding this comment.
Wonder if you could remove this hardcoding by using the submission template name / uuid, which you have, to query the SS API and retrieve the relevant request type key?
It would involve adding request_type to the submission template resource (v2 API) Sequencescape-side. A submission template can have multiple request types in an array, but the first one would be the relevant one.


Closes #
Changes proposed in this pull request
update disable workflow button condition
Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main]- Check story numbers included
- Check for debug code
- Check version