Y25-682 - Add RNAseq Workflow Branch#2700
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## Triomic_Epic #2700 +/- ##
================================================
+ Coverage 84.59% 84.97% +0.38%
================================================
Files 501 504 +3
Lines 20538 20779 +241
Branches 377 377
================================================
+ Hits 17374 17657 +283
+ Misses 3161 3119 -42
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yoldas
left a comment
There was a problem hiding this comment.
I have a few comments. Happy to discuss.
KatyTaylor
left a comment
There was a problem hiding this comment.
Looks good I think, just one more question added. Going to look at the Integration Suite PR next.
| LCMT RNA OdT Beads: LCMT RNA Denat/Hyb | ||
| LCMT RNA Denat/Hyb: LCMT RNA RT | ||
| LCMT RNA RT: LCMT RNA Preamp | ||
| LCMT RNA Preamp: LCMT cDNA Reserve |
There was a problem hiding this comment.
Could you please check this scenario?
Run the step-2 path, i.e., continue from LCMT RNA Preamp to LCMT cDNA Frag/ER
Do the charge and pass at LCMT cDNA Lib PCR XP.
Go back and continue from LCMT RNA Preamp to LCMT cDNA Reserve
(because LCMT cDNA Reserve was pre-created, continue with transfer)
We have a suspicion that because the same request is used for both branches, it may break.
| include DoesNotAllowLibraryPassing | ||
| end | ||
|
|
||
| state :processed do |
There was a problem hiding this comment.
I'm also unsure why you need this new 'processed' state when there are already 4 of them. Can't you use one of the existing ones?
There was a problem hiding this comment.
I'm also unsure why you need this new 'processed' state when there are already 4 of them. Can't you use one of the existing ones?
Yes I checked, but you need to go through them to get to passed state
Integ. suite PR:
https://gitlab.internal.sanger.ac.uk/psd/integration-suite/-/merge_requests/304