Y25-483 - Show Lot information using the v2 API#652
Open
Y25-483 - Show Lot information using the v2 API#652
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #652 +/- ##
===========================================
+ Coverage 80.31% 81.45% +1.13%
===========================================
Files 74 75 +1
Lines 1128 1197 +69
===========================================
+ Hits 906 975 +69
Misses 222 222
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BenTopping
reviewed
Feb 23, 2026
StephenHulme
previously approved these changes
Feb 23, 2026
Contributor
StephenHulme
left a comment
There was a problem hiding this comment.
Thanks for the change :)
StephenHulme
reviewed
Mar 2, 2026
Contributor
StephenHulme
left a comment
There was a problem hiding this comment.
Wrote the review, but forgot to submit it 🙈 - looks good but a couple questions.
Comment on lines
-137
to
+177
| assert_select '#pending_plate_7 > .plate_barcode', 'DN8' | ||
| assert_select '#pending_plate_7 > .plate_barcode', 'DN8C' |
Contributor
There was a problem hiding this comment.
This is an interesting change, what happened to the C?
Member
Author
There was a problem hiding this comment.
Not sure, it was just different to the others 👀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #563
Changes proposed in this pull request
Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main]- Check story numbers included
- Check for debug code
- Check version