Skip to content

Y25-483 - Show Lot information using the v2 API#652

Open
borhara wants to merge 12 commits intodevelopfrom
y25-483-show-v2-lot-info
Open

Y25-483 - Show Lot information using the v2 API#652
borhara wants to merge 12 commits intodevelopfrom
y25-483-show-v2-lot-info

Conversation

@borhara
Copy link
Member

@borhara borhara commented Feb 20, 2026

Closes #563

Changes proposed in this pull request

  • Modified logic for finding lots to use the SS V2

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

@codecov
Copy link

codecov bot commented Feb 20, 2026

Codecov Report

❌ Patch coverage is 87.32394% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.45%. Comparing base (b024bb4) to head (40a8a32).
⚠️ Report is 18 commits behind head on develop.

Files with missing lines Patch % Lines
app/models/presenter/qc_asset.rb 63.63% 8 Missing ⚠️
app/models/presenter/qcable.rb 96.15% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #652      +/-   ##
===========================================
+ Coverage    80.31%   81.45%   +1.13%     
===========================================
  Files           74       75       +1     
  Lines         1128     1197      +69     
===========================================
+ Hits           906      975      +69     
  Misses         222      222              
Flag Coverage Δ
pull_request 81.45% <87.32%> (+1.13%) ⬆️
push 81.51% <87.32%> (+1.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

StephenHulme
StephenHulme previously approved these changes Feb 23, 2026
Copy link
Contributor

@StephenHulme StephenHulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change :)

Copy link
Contributor

@StephenHulme StephenHulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrote the review, but forgot to submit it 🙈 - looks good but a couple questions.

Comment on lines -137 to +177
assert_select '#pending_plate_7 > .plate_barcode', 'DN8'
assert_select '#pending_plate_7 > .plate_barcode', 'DN8C'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an interesting change, what happened to the C?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, it was just different to the others 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Y25-483 - Show Lot information using the v2 API

3 participants