fix pixel sort #51
Merged
fix pixel sort #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The segmentation fault was caused by creating links that include excluded fragments which means fragments too small to sort. These excluded fragments have chain_id = -1, which caused the assertion failure. The fix ensure the following now : |
c-zhou
approved these changes
Oct 24, 2025
c-zhou
approved these changes
Oct 24, 2025
|
They all look good to me! |
|
My only suggestion is that in PretexView.cpp, we could define global constant strings for "3p_telomere" and "5p_telomere" to improve maintainability. This is however not critical. Chenxi |
Contributor
Author
thank you Chenxi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linked issue: #44