Performance improvements #265
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Using a high number of recursive
Ifwas slowing down the compilation.Profiling showed the bottleneck was
handleConflict, aO(N)operation that happens everytime we add a new Node.The fix
I switched the
resourceNodesSetto a "custom"Mapclass,ResourceNodesMap. This automatically manages the Map keys by concatenating the packType and the path components.Performance improvements
Before
iftook33.430siftook17.02sAfter
ifnow takes0.889s(x37 🚀)ifnow takes2.254s(x7.5 🚀 )More generally, the new O(1) complexity means Sandstone will better scale on large projects.