Skip to content

plan: validate targets before future --since exit #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sandover wants to merge 1 commit into from
Closed

plan: validate targets before future --since exit #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .ergo/events.jsonl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3365,3 +3365,4 @@
{"type":"state","ts":"2026-02-18T23:39:32.045309Z","data":{"id":"MUVZDJ","state":"done","ts":"2026-02-18T23:39:32.045309Z"}}
{"type":"state","ts":"2026-02-18T23:39:32.081186Z","data":{"id":"43GKYB","state":"done","ts":"2026-02-18T23:39:32.081186Z"}}
{"type":"new_task","ts":"2026-02-24T00:40:18.745182Z","data":{"id":"M5AALK","uuid":"3f43f787-64b2-40ec-8d60-385ffdd61f8a","epic_id":"","state":"todo","title":"docs/spec: note remote duplex --since rejection","body":"## Goal\n- Update the duplex spec to reflect that remote `POOLREF` rejects `--since`, matching CLI behavior and help text.\n- Ensure readers understand that `--since` only applies to local duplex refs.\n\n## Background/Rationale\n- `plasmite duplex` now returns a usage error for remote `--since`, but `spec/v0/SPEC.md` only documents remote `--create` rejection. This is a doc/behavior mismatch.\n\n## Acceptance Criteria\n- `spec/v0/SPEC.md` explicitly states that remote duplex refs reject `--since` (with guidance to use `--tail` or local refs).\n- The options section and/or remote-ref behavior notes are updated to avoid implying `--since` works remotely.\n- No other CLI semantics are changed.\n\n## Validation Gates\n- `just ci-fast`\n","created_at":"2026-02-24T00:40:18.745182Z"}}
{"type":"new_task","ts":"2026-02-24T18:50:23.03308Z","data":{"id":"MYWYFH","uuid":"7fb14155-7f20-4b95-b2e0-02af65d9d052","epic_id":"","state":"todo","title":"cli: validate targets before --since future exit","body":"## Goal\n- Ensure --since future checks do not bypass pool validation or remote restrictions.\n\n## Background\n- command_dispatch.rs returns early when since \u003e now before resolving the pool target.\n- This means remote refs with --since can exit 0 without the required usage error, and missing local pools are not reported.\n\n## Acceptance Criteria\n- `plasmite follow http://host/pool --since \u003cfuture\u003e` returns the same usage error as any remote --since.\n- `plasmite duplex http://host/pool --since \u003cfuture\u003e` returns the same usage error as any remote --since.\n- `plasmite follow missing --since \u003cfuture\u003e` reports NotFound with the usual missing-pool hint.\n- `plasmite duplex missing --since \u003cfuture\u003e` reports NotFound with the usual missing-pool hint.\n- For existing local pools, `--since` in the future still exits 0 with no output.\n\n## Validation Gates\n- cargo fmt --all\n- cargo clippy --all-targets -- -D warnings\n- just ci-fast\n","created_at":"2026-02-24T18:50:23.03308Z"}}
Loading