Skip to content

plan: validate targets before future --since exit #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sandover merged 1 commit into from
Feb 26, 2026
Merged

plan: validate targets before future --since exit #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .ergo/plans.jsonl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3501,3 +3501,4 @@
{"type":"result","ts":"2026-02-25T22:52:33.245514Z","data":{"task_id":"UMCU3R","summary":"Backfill actionable hints for hint-less Internal CLI errors","path":"src/main.rs","sha256_at_attach":"8eb075b555bf21e1c89fb32769c372444b039e6c1fd07ff0fdfb178e4620959d","mtime_at_attach":"2026-02-25T22:50:43.149382621Z","git_commit_at_attach":"3f34847dfa4e12c81c1885e43768df676f559830","ts":"2026-02-25T22:52:33.245514Z"}}
{"type":"body","ts":"2026-02-25T22:52:33.275686Z","data":{"id":"UMCU3R","body":"## Evidence\n- `src/command_dispatch.rs:117-123` constructs `ErrorKind::Internal` for runtime startup failure without `.with_hint(...)`.\n- `src/main.rs:125-127` only auto-applies hint enrichers for Corrupt/Io/Permission/Busy (`add_corrupt_hint` + `add_io_hint`).\n- `src/main.rs:2327-2362` renders a hint only if one already exists on the error.\n\n## Violated property\n- `docs/record/vision.md` operational clarity expectation (CLI errors should provide actionable remediation guidance).\n\n## Suggested fix\n- Add a final CLI-side hint enrichment pass for `ErrorKind::Internal` (and any remaining no-hint public kinds), or require all public constructors to supply a hint/doc reference.\n- Keep existing explicit hints as highest-priority and only backfill when missing.\n\n\n\n## Completion Note\n- Added a final CLI error enrichment pass (`add_internal_hint`) in `src/main.rs` run pipeline.\n- Internal errors without explicit hints now receive actionable remediation guidance while preserving existing explicit hints as higher priority.\n- This ensures JSON and human stderr surfaces consistently include hints for previously uncovered internal failure paths.\n","ts":"2026-02-25T22:52:33.275686Z"}}
{"type":"state","ts":"2026-02-25T22:52:33.275686Z","data":{"id":"UMCU3R","state":"done","ts":"2026-02-25T22:52:33.275686Z"}}
{"type":"new_task","ts":"2026-02-26T19:15:26.681695Z","data":{"id":"A5UGZS","uuid":"82fd4f33-2b7d-4e5e-acd1-9c2ed06a604d","epic_id":"","state":"todo","title":"cli: validate targets before --since future exit","body":"## Goal\n- Ensure --since future checks do not bypass pool validation or remote restrictions.\n\n## Background/Rationale\n- `command_dispatch.rs` can return early when `--since` is in the future before resolving the pool target.\n- This can let remote refs with `--since` exit 0 without the required usage error, and missing local pools are not reported.\n\n## Acceptance Criteria\n- `plasmite follow http://host/pool --since \u003cfuture\u003e` returns the same usage error as any remote `--since`.\n- `plasmite duplex http://host/pool --since \u003cfuture\u003e` returns the same usage error as any remote `--since`.\n- `plasmite follow missing --since \u003cfuture\u003e` reports NotFound with the usual missing-pool hint.\n- `plasmite duplex missing --since \u003cfuture\u003e` reports NotFound with the usual missing-pool hint.\n- For existing local pools, `--since` in the future still exits 0 with no output.\n\n## Validation Gates\n- `cargo fmt --all`\n- `cargo clippy --all-targets -- -D warnings`\n- `just ci-fast`\n","created_at":"2026-02-26T19:15:26.681695Z"}}
Loading