Conversation
|
Hi @amacado, Thanks for submitting this pull request. I'm not to keen about maintaining this in this repo, is this something you could consider contributing to https://github.com/DefinitelyTyped/DefinitelyTyped ? |
|
@sandeepmistry contributing to DefinitelyTyped/DefinitelyTyped is an option, it's just way more complicated and the requirements are higher than having the declaration right in the actual package. If you don't want to have it in this repo maybe someone else will find it useful so I'll keep a version in my fork if you don't mind. Currently I don't have the time to fulfill the requirements for DefinitelyTyped/DefinitelyTyped (maybe someone else will pick this up?) |
|
@sandeepmistry Publishing the types via DefinitelyTyped means that:
It's frustrating to hit this roadblock as a developer. I would expect the official blink1 libraries to facilitate the most common use cases (of which, types are now the norm). Otherwise we're just going to wind up with fragmentation because the official libraries aren't keeping up. |
|
I don't have an issue with this addition. I don't have much experience with TypeScript but I'll be happy to respond to any PRs and issues about it if they come up. How does that sound, @sandeepmistry? |
As proposed by @fushi in #37 I'll created a typescript declaration for
node-blink1.