Skip to content

introduce typescript declaration#39

Open
amacado wants to merge 1 commit intosandeepmistry:masterfrom
amacado:feature/typescript-declaration
Open

introduce typescript declaration#39
amacado wants to merge 1 commit intosandeepmistry:masterfrom
amacado:feature/typescript-declaration

Conversation

@amacado
Copy link
Contributor

@amacado amacado commented Dec 24, 2021

As proposed by @fushi in #37 I'll created a typescript declaration for node-blink1.

@sandeepmistry
Copy link
Owner

Hi @amacado,

Thanks for submitting this pull request. I'm not to keen about maintaining this in this repo, is this something you could consider contributing to https://github.com/DefinitelyTyped/DefinitelyTyped ?

@amacado
Copy link
Contributor Author

amacado commented Dec 24, 2021

@sandeepmistry contributing to DefinitelyTyped/DefinitelyTyped is an option, it's just way more complicated and the requirements are higher than having the declaration right in the actual package. If you don't want to have it in this repo maybe someone else will find it useful so I'll keep a version in my fork if you don't mind. Currently I don't have the time to fulfill the requirements for DefinitelyTyped/DefinitelyTyped (maybe someone else will pick this up?)

@mloffer
Copy link

mloffer commented Apr 2, 2022

@sandeepmistry Publishing the types via DefinitelyTyped means that:

  1. Developers need to know to pull yet another package to get types, and
  2. The maintainer of this library has no intention of updating those types when releasing a new version, breaking existing builds that depend on types until the types are patched (by someone else)

It's frustrating to hit this roadblock as a developer. I would expect the official blink1 libraries to facilitate the most common use cases (of which, types are now the norm). Otherwise we're just going to wind up with fragmentation because the official libraries aren't keeping up.

@todbot
Copy link
Collaborator

todbot commented Apr 2, 2022

I don't have an issue with this addition. I don't have much experience with TypeScript but I'll be happy to respond to any PRs and issues about it if they come up.

How does that sound, @sandeepmistry?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants