Level 7b

[sandeepbarnwal]

This PR contains tasks upto 7b level from https://engineering.beescloud.com/docs/engineering-cbci/latest/onboarding/practical-work-plugin

[jglick]

Missing a getter.

[sandeepbarnwal]

Adding getter resolved this. I was able to get generated script like below

onboarding name: 'sa', selectedCategory: 'b5d06f12-6446-47de-8abb-143380ed30af'

So far I didn't need to expose gettter as I was selecting the categories from dropdown
 which is populated from global config's data and selectedCategory is used within the
 class OnboardingTaskBuilder. I had not added getter as it was not required. 
Is it always recommended to add getters even if a property is not being used (atleast currently) 
outside the object's context?

[jglick]

If you expect the snippet generator to work then you must have getters for all fields. (Or the fields themselves can be public.)

[sandeepbarnwal]

Okay, thanks.
PS: In my opinion, snippet generator could generate the snippet considering only the properties which are public (either via getter or public) and ignoring the private properties. That would be less confusing (atleast to newcomers).

[sandeepbarnwal]

Discussed with Thor and came to a conclusion tha it was failing for a case where you have data bound setter but not the getter. Private properties without public scope (getter and setter) are ignored as expected.

[scherler]

Suggested change

	## Issues
	## Contributing
	TODO review the default [CONTRIBUTING](https://github.com/jenkinsci/.github/blob/master/CONTRIBUTING.md) file and make sure it is appropriate for your plugin, if not then add your own one adapted from the base file
	Refer to our [contribution guidelines](https://github.com/jenkinsci/.github/blob/master/CONTRIBUTING.md)

[scherler]

I guess something like sandeep onboarding plugin

[sandeepbarnwal]

noted

[scherler]

There are a lot of those methods, maybe it makes sense to extract them to a class

[sandeepbarnwal]

let me re-check