create temp files in output directory, not in input dir#7
Open
TyberiusPrime wants to merge 1 commit intosandberg-lab:mainfrom
Open
create temp files in output directory, not in input dir#7TyberiusPrime wants to merge 1 commit intosandberg-lab:mainfrom
TyberiusPrime wants to merge 1 commit intosandberg-lab:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bamboozle tries to create it's temp files next to the input file,
instead of next to the output file.
This of course fails if your input files are in non-writable directories/filesystems.
The PR fixes it to write the temp files in the output directory - which must be writable anyway - instead.