Introduces support for sprockets 4.y.z releases

[jrgriffiniii]

Resolves #310 by ensuring that sprockets 4.y.z releases can be used. Also provides a solution for supporting Rails 6.0.0 releases.

[jrgriffiniii]

This remains broken given that I can't seem to understand why I'm breaking the build with engine_cart. Currently, attempting to keep webpacker from being installed with the Rails application generator involves invoking rails new --skip-webpacker-install (or, preferably, rails new --skip-javascript). Adding either to the file .engine_cart.yml does not seem to prevent webpacker from being added as a dependency, and from the generator from installing NPM packages for Webpack.

[jrgriffiniii]

This needs to be removed, Core Components are no longer required to support Rails 4.y.z releases.

[jrgriffiniii]

This shouldn't be here, but I cannot disable engine_cart from inserting webpacker as a dependency.

[jrgriffiniii]

Sprockets becomes a problem with engine_cart unless --skip-sprockets is passed to the Rails generator. This needs to be resolved in order to remove sprockets as a dependency of the Gem (at least, for Rails 6.y.z releases).

[jrgriffiniii]

This provides a first step towards supporting Rails 6.0.z and Sprockets 4.y.z.

[jrgriffiniii]

From what I could determine, the modification which I need lies somewhere in https://github.com/cbeer/engine_cart/blob/master/lib/engine_cart/configuration.rb#L54. If the value of options[:rails_options] is not split on whitespace (using a method such as #split(/\s/)), then the overridden options passed in .engine_cart.yml will not parse them properly.

[jrgriffiniii]

I'm going to look to offer an update with https://github.com/cbeer/engine_cart/compare/master...jrgriffiniii:jrgriffiniii-split-rails-options?expand=1

[jrgriffiniii]

Further progress on this is blocked until cbeer/engine_cart#99 (or some guidance) directs me on how I wasn't able to generate the internal_test_app with --skip-javascript.

[jrochkind]

Nope, this has nothing to do with webpacker. In fact, it's the opposite -- what this line of code is doing is making sure that Sprockets will still handle Javascript, even if you are using Sprockets 4.

Since:

• Sprockets 4 (unlike sprockets 3) will use this app/assets/config/mannifest.js file
• Rails 6 (unlike Rails 5) will not include the link_directory ../javascripts .js line in the generated app/assets/config/manifest.js file, since Rails 6 thinks you shouldn't use Sprockets for JS.

So what you're doing is making it so Sprockets will still do JS in Rails 6.0.1 with Sprockets 4 -- nothing to do with webpacker at all.

So at least, you probably want to remove/change this comment.

But also, since this is a generator -- you probably want to document where (README?) that the browse-everything installer under Rails 6 is going to re-enable Sprockets handling of JS, and add a line to your application.html.erb layout that generates a <script> tag for a sprockets-compiled application.js in addition to the existing webpacker-compiled one.

Which is not ideal -- but is better than browse-everything not working at all, it's what we've got for Rails 6 right now.

[jrochkind]

Hi I can't upgrade to browse-everything 1.0.2 (or any future b-e's), because I am already using sprockets 4. Which is working fine with browse-everything, it's not causing a problem for me. But b-e 1.0.2 no longer allows it in the gemspec

What is the status of this PR, do you think? I don't think it's okay that b-e 1.0.1 works fine with sprockets 4, but 1.0.2 will not allow a using app to use sprockets 4. I don't want to have to downgrade my sprockets to keep using b-e.

[hackartisan]

superceded by #358