comment to clarify the usage of "filepicker"#2
Open
manpenaloza wants to merge 1 commit intosamuxyz:masterfrom
Open
comment to clarify the usage of "filepicker"#2manpenaloza wants to merge 1 commit intosamuxyz:masterfrom
manpenaloza wants to merge 1 commit intosamuxyz:masterfrom
Conversation
i was wondering why setKey() on the filepicker object worked out, especially as there is no import declaration. made my way through the files until i found the api request in the root index.html file.
manpenaloza
changed the title
samuxyz
approved these changes
Jan 2, 2017
Owner
samuxyz
left a comment
samuxyz
left a comment
There was a problem hiding this comment.
You are right, a comment line to clarify the thing would help.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i was wondering why setKey() on the filepicker object worked out, especially as there is no import declaration. made my way through the files until i found the api request in the root index.html file.