Open
Conversation
Owner
|
@hiulit I'm not getting the problem you have? Is it you don't want the dlls to be exported when steam integration is disabled? |
Author
|
Exactly! When Steam Integration is disabled, I don't want the dlls to be compiled/copied. |
Owner
|
Ok seems like a good feature. Will checkout your change and try soon 🔜 |
|
This is a great PR – especially for multi-platform games. Hoping it'll make it in! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've created a new
SteamDependencyLibrariesclass to enable/disable the dependency libraries, so they won't be compiled when "Steam integration" is disabled.Basically, what it does, is when the user clicks on the "Disable Steam Integration" checkbox, it creates backups of all the
.gdnsand.gdnlib, and then removes stuff from the originals so the dependency libraries won't be compiled.When the user enables the Steam Integration, all those files are reverted back to its originals.
As a little bonus, I've fixed an issue. When the "Steam integration" is disabled and the user disables the plugin, the disabled state stays and when the user enables back the plugin it still disabled. I made it so it is enabled when the plugin is enabled.