Skip to content
This repository was archived by the owner on Feb 6, 2020. It is now read-only.

Popper!#10

Closed
pemrouz wants to merge 1 commit intosammyt:masterfrom
pemrouz:master
Closed

Popper!#10
pemrouz wants to merge 1 commit intosammyt:masterfrom
pemrouz:master

Conversation

@pemrouz
Copy link

@pemrouz pemrouz commented Sep 17, 2015

Just run popper (or popper -b, where -b means an empty list of browsers, which overrides the list of browsers in the .popper.yml, which basically means, don't spawn any browsers in BrowserStack for this run, which is useful if you are just running locally).

This is what :1945/dashboard looks like (note: kept dashboard UI simple, so it just categorises by top-level describes - I prefer having a flatter list so I can see more rows):

image

This is what the test agents on :1945 look like:

image

This is what npm test looks like (i.e. results from Travis):

image

This is what running the same tests on node via npm test-node (i.e. mocha) looks like (it;s on the roadmap to have popper pull these results into the same dashboard):

image

"test-node": "mocha",
"clean": "rm -rf lib",
"compile": "mkdir -p lib && browserify src/rhumb.js --standalone rhumb -o lib/rhumb.js",
"compile": "npm run clean && mkdir lib && browserify src/rhumb.js --standalone rhumb -o lib/rhumb.js",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, your mkdir -p lib was creating a -p and lib folder for me. Probably because Windows..

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah most def because windows. :o)

@mstade
Copy link
Collaborator

mstade commented Sep 17, 2015

This is very cool – thanks buddy! However, I'm right in the process of moving to tape instead of mocha. There are various reasons for this, but composability is a major one. I opened up pemrouz/popper#6 because of that. Currently looking to see if there's anything I can do to help, it's a very nifty tool you've written.

@pemrouz
Copy link
Author

pemrouz commented Sep 17, 2015

Awesome, well this was super simple to do. Just had to point popper to your test.rhumb.js. Let's take another look once you've checked in the new tape tests.

@mstade
Copy link
Collaborator

mstade commented Sep 17, 2015

I can do that right now, gimme a sec!

@mstade
Copy link
Collaborator

mstade commented Sep 17, 2015

Alright, pushed the new tests (see #11.)

@mstade mstade mentioned this pull request Sep 22, 2015
@mstade
Copy link
Collaborator

mstade commented Sep 22, 2015

This issue was moved to websdk/rhumb#8

@mstade mstade closed this Sep 22, 2015
@mstade mstade mentioned this pull request Sep 22, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments