feat: add translations page with dynamic seo content#1
Open
malikdotjs wants to merge 2 commits intosamk-dev:mainfrom
Open
feat: add translations page with dynamic seo content#1malikdotjs wants to merge 2 commits intosamk-dev:mainfrom
malikdotjs wants to merge 2 commits intosamk-dev:mainfrom
Conversation
samk-dev
requested changes
Jun 23, 2024
Owner
samk-dev
left a comment
There was a problem hiding this comment.
Hey thank you for the PR,
useSetI18nParamsas shown in the screenshot Typescript complains about it being ini18nconfig key innuxt.configwhich you can checknode_modules/@nuxtjs/i18n/dist/module.d.tson line371and also the docs doesn't mention that it has to be set fromnuxt.config- The starter is using npm as package manager, which does not limit you to use other package managers when you use the starter for your projects by deleting
package-lock.jsonand then install deps with your preferred package manager so yarn.lock is not needed here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Description
This PR adds a translations page to demonstrate dynamic meta tag setting with i18n.