Skip to content

Fix exponential macro expansion in const_max! #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mercnz wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix exponential macro expansion in const_max! #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions crates/rhdl-core/src/bitx/dyn_bit_manip.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,16 +141,17 @@ pub fn move_nbits_to_msb<T: Copy>(a: &[T], n: usize) -> Vec<T> {
[right, left].concat()
}

/// Const helper to compute maximum of two usize values.
pub const fn const_max2(a: usize, b: usize) -> usize {
if a > b { a } else { b }
}

#[macro_export]
/// Macro to compute the maximum of a list of constant expressions at compile time.
macro_rules! const_max {
($x: expr) => ($x);
($x: expr, $($z: expr), +) => (
if $x > const_max!($($z), +) {
$x
} else {
const_max!($($z), +)
}
$crate::bitx::dyn_bit_manip::const_max2($x, const_max!($($z),+))
);
}

Expand Down