Skip to content

WIP - [ignore] Added race condition check to tests #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
samiib wants to merge 3 commits into
base: master
Choose a base branch
from
Open

WIP - [ignore] Added race condition check to tests #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
300b919
[ignore] Added race condition check to tests
samiib May 15, 2024
0190fa0
[ignore] Split TestAccAciRestManaged_import into seperate tests
samiib May 16, 2024
f118801
[ignore] Skip troublesome aci_rest_managed test in CI until it gets f…
samiib May 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,9 @@ jobs:
terraform_version: '1.7.*'
terraform_wrapper: false
- name: Terraform Acceptance Test (APIC ${{ matrix.apic_host.name }})
run: go test github.com/CiscoDevNet/terraform-provider-aci/v2/internal/provider -v -timeout 300m -coverprofile=coverage.out -covermode=atomic
# TODO: Fix TestAccAciRestManaged_importWithIpv6 to resolve data race failures occurring in the CI
# https://github.com/CiscoDevNet/terraform-provider-aci/issues/1218
run: go test github.com/CiscoDevNet/terraform-provider-aci/v2/internal/provider -v -race -timeout 300m -coverprofile=coverage.out -covermode=atomic -skip TestAccAciRestManaged_importWithIpv6
env:
TF_ACC: '1'
TF_ACC_STATE_LINEAGE: '1'
Expand All @@ -87,4 +89,4 @@ jobs:
if: ${{ matrix.apic_host.name == 'v6.0'}}
uses: codecov/codecov-action@v4
with:
token: ${{ secrets.CODECOV_TOKEN }}
token: ${{ secrets.CODECOV_TOKEN }}
22 changes: 22 additions & 0 deletions internal/provider/resource_aci_rest_managed_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,6 +311,17 @@ func TestAccAciRestManaged_import(t *testing.T) {
resource.TestCheckResourceAttr("aci_rest_managed.import", "child.#", "2"),
),
},
},
})
}

func TestAccAciRestManaged_importWithIpv6(t *testing.T) {
name := acctest.RandStringFromCharSet(10, acctest.CharSetAlphaNum)

resource.Test(t, resource.TestCase{
PreCheck: func() { testAccPreCheck(t) },
ProtoV6ProviderFactories: testAccProtoV6ProviderFactories,
Steps: []resource.TestStep{
{
Config: testAccAciRestManagedConfig_importWithIpv6(name, "import", "2001:1:2::5/28", "2001:1:2::5/28"),
Check: resource.ComposeTestCheckFunc(
Expand Down Expand Up @@ -388,6 +399,17 @@ func TestAccAciRestManaged_import(t *testing.T) {
resource.TestCheckResourceAttr("aci_rest_managed.bd_import_2", "child.1.content.tnFvCtxName", "VRF2"),
),
},
},
})
}

func TestAccAciRestManaged_importWithBracket(t *testing.T) {
name := acctest.RandStringFromCharSet(10, acctest.CharSetAlphaNum)

resource.Test(t, resource.TestCase{
PreCheck: func() { testAccPreCheck(t) },
ProtoV6ProviderFactories: testAccProtoV6ProviderFactories,
Steps: []resource.TestStep{
{
Config: testAccAciRestManagedConfig_importWithBracket(name),
Check: resource.ComposeTestCheckFunc(
Expand Down