Skip to content

[Precogs Alert] Insecure Direct Object Reference (IDOR) detected (CWE-639, Risk: High) #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sameer6pre wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Precogs Alert] Insecure Direct Object Reference (IDOR) detected (CWE-639, Risk: High) #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 30 additions & 14 deletions orbit-app/src/components/DownloadFile.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,21 +5,37 @@ function DownloadFile() {
const [fileData, setFileData] = useState(null);
const [fileId, setFileId] = useState('');

const handleDownload = async () => {
try {
const response = await axios.get(`${BASE_URL}/${fileId}`);

setFileData(response.data);

const link = document.createElement('a');
link.href = URL.createObjectURL(new Blob([response.data], { type: 'application/octet-stream' }));
link.download = fileId; // File downloaded with ID
link.click();
} catch (error) {
console.error('Error downloading file:', error);
alert('Failed to download the file. Please try again.');
async () => {
try {
// Validate and sanitize the fileId parameter
if (!isValidFileId(fileId)) {
throw new Error('Invalid file ID');
}
};

const response = await axios.get(`${BASE_URL}/${fileId}`);

setFileData(response.data);

const link = document.createElement('a');
link.href = URL.createObjectURL(new Blob([response.data], { type: 'application/octet-stream' }));
link.download = sanitizeFileName(fileId); // Ensure the filename is safe
link.click();
} catch (error) {
console.error('Error downloading file:', error);
alert('Failed to download the file. Please try again.');
}
}

// Helper functions for validation and sanitization
function isValidFileId(fileId) {
// Implement validation logic, e.g., regex check or database lookup
return /^[a-zA-Z0-9_-]+$/.test(fileId);
}

function sanitizeFileName(fileName) {
// Implement sanitization logic, e.g., remove unsafe characters
return fileName.replace(/[^a-zA-Z0-9_-]/g, '_');
}

return (
<div>
Expand Down