Use current-error-port for logging output#12
Open
otherjoel wants to merge 2 commits intosamdphillips:mainfrom
Open
Use current-error-port for logging output#12otherjoel wants to merge 2 commits intosamdphillips:mainfrom
current-error-port for logging output#12otherjoel wants to merge 2 commits intosamdphillips:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although there is not universal agreement, there seems to be a long-standing doctrine of using stderr for logging output.
raco pollen startweb server uses stderr for logging output.This isn’t merely an ideological thing; there is one minor practical difference, which is that stdout is usually block-buffered by default while stderr is unbuffered. I did run into issues running
raco static-webas a subprocess inside a GUI program due to this difference. On the other hand, this is something I can work around any number of ways, and others are very unlikely to be affected by stdout’s buffering behavior.There would be one more significant practical difference, if
raco-static-webhad any non-logging “normal output” that would be likely to be piped to other programs, and which could be said to be polluted by the logging info. That doesn’t apply here, though it might in the future.Anyway, this is just a suggestion, not something I have a strong opinion about, despite the lengthy explanation I am giving here.