Updated to python3 and added lots of new features to GUI#19
Open
mohak300501 wants to merge 1 commit intosamb8s:masterfrom
Open
Updated to python3 and added lots of new features to GUI#19mohak300501 wants to merge 1 commit intosamb8s:masterfrom
mohak300501 wants to merge 1 commit intosamb8s:masterfrom
Conversation
tycohen
requested changes
May 14, 2024
Collaborator
tycohen
left a comment
tycohen
left a comment
There was a problem hiding this comment.
Thank you for working on this! There are a couple issues that are preventing me from merging this in.
- You have 30 file changes and multiple feature additions in a single commit. This will create difficulties with debugging and conflict resolution in the future. Please keep commits to one or a few testable units or at least a single feature.
- I noticed you've changed print statements and a few imports to python3. This alone is not sufficient to update to python3 without breaking backwards compatibility, which we want to maintain. (For example any user's pickled population objects created with a previous version of PsrPopPy would not be readable under these changes.) Consider using a translation tool like 2to3, though manual changes will also need to be made.
I'd be happy to review a PR with these changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I updated this pulsar population simulation package as part of my dissertation project for my Integrated Masters in Physics at the Indian Institute of Technology, Roorkee (IITR).