Skip to content

feat(plasma-new-hope): Add invariants support [DONT MERGE] #1983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
neretin-trike wants to merge 3 commits into
base: dev
Choose a base branch
from
Draft

feat(plasma-new-hope): Add invariants support [DONT MERGE] #1983

neretin-trike wants to merge 3 commits into from

Conversation

@neretin-trike
Copy link
Collaborator

@neretin-trike neretin-trike commented May 20, 2025 •
edited by Salute-Eva
Loading

Core

  • Добавлена поддержка "инвариантных" стилей, которые применяются к компоненту в независимости от выбранной вариации.

Пример конфига:

{
    ...,
    invariants: css`
        ${iconButtonTokens.iconButtonDisabledOpacity}: 0.4;
        ${iconButtonTokens.iconButtonFocusColor}: var(--surface-accent);
    `,
}

What/why changed

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/plasma-asdk@0.355.0-canary.1983.19295272379.0
npm install @salutejs/plasma-b2c@1.597.0-canary.1983.19295272379.0
npm install @salutejs/plasma-giga@0.324.0-canary.1983.19295272379.0
npm install @salutejs/plasma-new-hope@0.341.0-canary.1983.19295272379.0
npm install @salutejs/plasma-web@1.599.0-canary.1983.19295272379.0
npm install @salutejs/sdds-bizcom@0.329.0-canary.1983.19295272379.0
npm install @salutejs/sdds-crm@0.328.0-canary.1983.19295272379.0
npm install @salutejs/sdds-cs@0.333.0-canary.1983.19295272379.0
npm install @salutejs/sdds-dfa@0.327.0-canary.1983.19295272379.0
npm install @salutejs/sdds-finai@0.320.0-canary.1983.19295272379.0
npm install @salutejs/sdds-insol@0.324.0-canary.1983.19295272379.0
npm install @salutejs/sdds-netology@0.328.0-canary.1983.19295272379.0
npm install @salutejs/sdds-scan@0.327.0-canary.1983.19295272379.0
npm install @salutejs/sdds-serv@0.328.0-canary.1983.19295272379.0
# or 
yarn add @salutejs/plasma-asdk@0.355.0-canary.1983.19295272379.0
yarn add @salutejs/plasma-b2c@1.597.0-canary.1983.19295272379.0
yarn add @salutejs/plasma-giga@0.324.0-canary.1983.19295272379.0
yarn add @salutejs/plasma-new-hope@0.341.0-canary.1983.19295272379.0
yarn add @salutejs/plasma-web@1.599.0-canary.1983.19295272379.0
yarn add @salutejs/sdds-bizcom@0.329.0-canary.1983.19295272379.0
yarn add @salutejs/sdds-crm@0.328.0-canary.1983.19295272379.0
yarn add @salutejs/sdds-cs@0.333.0-canary.1983.19295272379.0
yarn add @salutejs/sdds-dfa@0.327.0-canary.1983.19295272379.0
yarn add @salutejs/sdds-finai@0.320.0-canary.1983.19295272379.0
yarn add @salutejs/sdds-insol@0.324.0-canary.1983.19295272379.0
yarn add @salutejs/sdds-netology@0.328.0-canary.1983.19295272379.0
yarn add @salutejs/sdds-scan@0.327.0-canary.1983.19295272379.0
yarn add @salutejs/sdds-serv@0.328.0-canary.1983.19295272379.0

@github-actions
Copy link
Contributor

github-actions bot commented May 20, 2025

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1983/

@github-actions
Copy link
Contributor

github-actions bot commented May 20, 2025 •
edited
Loading

Documentation preview deployed!

website: https://plasma.sberdevices.ru/pr/pr-1983/
asdk storybook: https://plasma.sberdevices.ru/pr/pr-1983/asdk-storybook/
b2c storybook: https://plasma.sberdevices.ru/pr/pr-1983/b2c-storybook/
giga storybook: https://plasma.sberdevices.ru/pr/pr-1983/giga-storybook/
new-hope storybook: https://plasma.sberdevices.ru/pr/pr-1983/new-hope-storybook/
web storybook: https://plasma.sberdevices.ru/pr/pr-1983/web-storybook/
sdds-bizcom storybook: https://plasma.sberdevices.ru/pr/pr-1983/sdds-bizcom-storybook/
sdds-crm storybook: https://plasma.sberdevices.ru/pr/pr-1983/sdds-crm-storybook/
sdds-cs storybook: https://plasma.sberdevices.ru/pr/pr-1983/sdds-cs-storybook/
sdds-dfa storybook: https://plasma.sberdevices.ru/pr/pr-1983/sdds-dfa-storybook/
sdds-finai storybook: https://plasma.sberdevices.ru/pr/pr-1983/sdds-finai-storybook/
sdds-insol storybook: https://plasma.sberdevices.ru/pr/pr-1983/sdds-insol-storybook/
sdds-netology storybook: https://plasma.sberdevices.ru/pr/pr-1983/sdds-netology-storybook/
sdds-scan storybook: https://plasma.sberdevices.ru/pr/pr-1983/sdds-scan-storybook/
sdds-serv storybook: https://plasma.sberdevices.ru/pr/pr-1983/sdds-serv-storybook/
ui storybook: https://plasma.sberdevices.ru/pr/pr-1983/ui-storybook/

Yeti-or
Yeti-or reviewed May 20, 2025
View reviewed changes
Copy link
Contributor

@Yeti-or Yeti-or left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

В этом пр надо поправить код компонента: 9a29959#r157471608 а смотреть как это будет работать в реальном Button мы не будем ?

packages/plasma-new-hope/src/engines/emotion.tsx
${({ staticVariants }) => staticVariants};
${({ dynamicVariants }) => dynamicVariants};
${({ intersectionStyles }) => intersectionStyles};
${({ invariants }) => invariants};
Copy link
Contributor

@Yeti-or Yeti-or May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

вопрос такой если я напишу в варицаии disableOpacity отличающийся от того что написано в инварианте, кто победит?

Copy link
Collaborator Author

@neretin-trike neretin-trike May 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

хм, мне кажется победит инвариант, т.к. он в конце стоит

Copy link
Collaborator

@Yakutoc Yakutoc May 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А как мы определяем порядок кто должен быть первым и последним?

@neretin-trike
Copy link
Collaborator Author

neretin-trike commented May 21, 2025

В этом пр надо поправить код компонента: 9a29959#r157471608 а смотреть как это будет работать в реальном Button мы не будем ?

да, надо будет убрать комменты. Ну я бы пока не хотел менять в реальных компонентах это. Но предлагаю делать точечно, когда появится необходимость при генерации

@neretin-trike neretin-trike force-pushed the neretinaa/add-invariants-support branch from 73416bb to 97ab015 Compare May 30, 2025 09:02
@neretin-trike neretin-trike force-pushed the neretinaa/add-invariants-support branch from 97ab015 to 85fe43f Compare June 6, 2025 07:28
@neretin-trike neretin-trike force-pushed the neretinaa/add-invariants-support branch from 85fe43f to d6645ad Compare June 6, 2025 08:40
@neretin-trike neretin-trike marked this pull request as draft June 6, 2025 08:45
@neretin-trike neretin-trike force-pushed the neretinaa/add-invariants-support branch from d6645ad to b0c9494 Compare June 19, 2025 11:57
@neretin-trike neretin-trike force-pushed the neretinaa/add-invariants-support branch from b0c9494 to 27eb653 Compare June 19, 2025 12:24
@Yakutoc Yakutoc changed the title feat(plasma-new-hope): Add invariants support feat(plasma-new-hope): Add invariants support [DONT MERGE] Jun 25, 2025
@neretin-trike neretin-trike force-pushed the neretinaa/add-invariants-support branch from 27eb653 to 909acc3 Compare June 26, 2025 08:31
@neretin-trike neretin-trike force-pushed the neretinaa/add-invariants-support branch from 909acc3 to b42df10 Compare November 12, 2025 10:02
@neretin-trike neretin-trike force-pushed the neretinaa/add-invariants-support branch from b42df10 to 4457f11 Compare November 12, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Yeti-or Yeti-or Yeti-or left review comments

@Yakutoc Yakutoc Yakutoc approved these changes

@TitanKuzmich TitanKuzmich Awaiting requested review from TitanKuzmich TitanKuzmich is a code owner

@shuga2704 shuga2704 Awaiting requested review from shuga2704 shuga2704 is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@neretin-trike @Yeti-or @Yakutoc