Skip to content

PLASMA-4301: refactor DatePicker input validation #1916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
TitanKuzmich wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

PLASMA-4301: refactor DatePicker input validation #1916

TitanKuzmich wants to merge 4 commits into from

Conversation

@TitanKuzmich
Copy link
Contributor

@TitanKuzmich TitanKuzmich commented Apr 14, 2025 •
edited by Salute-Eva
Loading

Core

DatePicker

  • изменена валидация ввода дат в DatePicker
  • исправлено поведение автофокуса на инпутах после ввода дат
  • onCommit вызывается при корректном вводе даты
  • добавлен проброс дат в виде js объекта и в формате iso
  • value расширен до типа строки

What/why changed

При вводе даты отрабатывает строгая валидаци, чтобы нельзя было ввести ничего лишнего и пользователю не нужно было дополнительно валидировать значение.

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/plasma-asdk@0.335.0-canary.1916.14472644120.0
npm install @salutejs/plasma-b2c@1.577.0-canary.1916.14472644120.0
npm install @salutejs/plasma-giga@0.304.0-canary.1916.14472644120.0
npm install @salutejs/plasma-hope@1.339.0-canary.1916.14472644120.0
npm install @salutejs/plasma-icons@1.217.0-canary.1916.14472644120.0
npm install @salutejs/plasma-new-hope@0.321.0-canary.1916.14472644120.0
npm install @salutejs/plasma-ui@1.315.0-canary.1916.14472644120.0
npm install @salutejs/plasma-web@1.579.0-canary.1916.14472644120.0
npm install @salutejs/sdds-clfd-auto@0.308.0-canary.1916.14472644120.0
npm install @salutejs/sdds-cs@0.313.0-canary.1916.14472644120.0
npm install @salutejs/sdds-dfa@0.307.0-canary.1916.14472644120.0
npm install @salutejs/sdds-finportal@0.300.0-canary.1916.14472644120.0
npm install @salutejs/sdds-insol@0.304.0-canary.1916.14472644120.0
npm install @salutejs/sdds-serv@0.308.0-canary.1916.14472644120.0
npm install @salutejs/plasma-themes@0.32.0-canary.1916.14472644120.0
# or 
yarn add @salutejs/plasma-asdk@0.335.0-canary.1916.14472644120.0
yarn add @salutejs/plasma-b2c@1.577.0-canary.1916.14472644120.0
yarn add @salutejs/plasma-giga@0.304.0-canary.1916.14472644120.0
yarn add @salutejs/plasma-hope@1.339.0-canary.1916.14472644120.0
yarn add @salutejs/plasma-icons@1.217.0-canary.1916.14472644120.0
yarn add @salutejs/plasma-new-hope@0.321.0-canary.1916.14472644120.0
yarn add @salutejs/plasma-ui@1.315.0-canary.1916.14472644120.0
yarn add @salutejs/plasma-web@1.579.0-canary.1916.14472644120.0
yarn add @salutejs/sdds-clfd-auto@0.308.0-canary.1916.14472644120.0
yarn add @salutejs/sdds-cs@0.313.0-canary.1916.14472644120.0
yarn add @salutejs/sdds-dfa@0.307.0-canary.1916.14472644120.0
yarn add @salutejs/sdds-finportal@0.300.0-canary.1916.14472644120.0
yarn add @salutejs/sdds-insol@0.304.0-canary.1916.14472644120.0
yarn add @salutejs/sdds-serv@0.308.0-canary.1916.14472644120.0
yarn add @salutejs/plasma-themes@0.32.0-canary.1916.14472644120.0

@TitanKuzmich TitanKuzmich self-assigned this Apr 14, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 14, 2025

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1916/

@github-actions
Copy link
Contributor

github-actions bot commented Apr 14, 2025

Documentation preview deployed!

website: https://plasma.sberdevices.ru/pr/pr-1916/
asdk storybook: https://plasma.sberdevices.ru/pr/pr-1916/asdk-storybook/
b2c storybook: https://plasma.sberdevices.ru/pr/pr-1916/b2c-storybook/
giga storybook: https://plasma.sberdevices.ru/pr/pr-1916/giga-storybook/
new-hope storybook: https://plasma.sberdevices.ru/pr/pr-1916/new-hope-storybook/
web storybook: https://plasma.sberdevices.ru/pr/pr-1916/web-storybook/
sdds-cs storybook: https://plasma.sberdevices.ru/pr/pr-1916/sdds-cs-storybook/
sdds-dfa storybook: https://plasma.sberdevices.ru/pr/pr-1916/sdds-dfa-storybook/
sdds-finportal storybook: https://plasma.sberdevices.ru/pr/pr-1916/sdds-finportal-storybook/
sdds-insol storybook: https://plasma.sberdevices.ru/pr/pr-1916/sdds-insol-storybook/
sdds-serv storybook: https://plasma.sberdevices.ru/pr/pr-1916/sdds-serv-storybook/
ui storybook: https://plasma.sberdevices.ru/pr/pr-1916/ui-storybook/

@TitanKuzmich TitanKuzmich marked this pull request as ready for review April 15, 2025 12:06
@github-actions github-actions bot requested review from Yakutoc and shuga2704 and removed request for Yakutoc, Yeti-or, neretin-trike and shuga2704 April 15, 2025 12:06
neretin-trike
neretin-trike reviewed Apr 15, 2025
View reviewed changes
packages/plasma-new-hope/src/components/DatePicker/utils/valueFormatter.ts
isoDate,
originalDate,
};
};
Copy link
Collaborator

@neretin-trike neretin-trike Apr 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ох жесть 😨 Откуда столько? Разве здесь использование маски не подошло бы, например? 🤔

Copy link
Contributor Author

@TitanKuzmich TitanKuzmich Apr 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Неа, потому что есть буквенный ввод месяца. Если б этого не было, маска подошла бы

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neretin-trike neretin-trike neretin-trike left review comments

@Yakutoc Yakutoc Awaiting requested review from Yakutoc Yakutoc is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

@TitanKuzmich TitanKuzmich

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TitanKuzmich @neretin-trike