Fix salt-ssh tests with newer Python#68757
Draft
marmarek wants to merge 3 commits intosaltstack:3007.xfrom
Draft
Fix salt-ssh tests with newer Python#68757marmarek wants to merge 3 commits intosaltstack:3007.xfrom
marmarek wants to merge 3 commits intosaltstack:3007.xfrom
Conversation
marmarek
force-pushed
the
import-conflict-tests
branch
from
ad6dd5b to
6d3ee68
Compare
marmarek
force-pushed
the
import-conflict-tests
branch
from
6d3ee68 to
369e3e1
Compare
marmarek
force-pushed
the
import-conflict-tests
branch
from
369e3e1 to
8af7d98
Compare
Speed up CI run, and also put less load on it.
marmarek
force-pushed
the
import-conflict-tests
branch
from
8af7d98 to
a279aaa
Compare
let them run on PR workflow, without enabling all slow tests
marmarek
force-pushed
the
import-conflict-tests
branch
from
a279aaa to
1b8eae3
Compare
Contributor
Author
|
Hm, (re-)enabling tests on Fedora 42 might be a bit too much work for this PR... Any advice how to proceed? Should I focus on extending salt-ssh tests on Ubuntu 24.04, or maybe do add Fedora 42, but skip most tests there? Or some other approach? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enable tests for salt-ssh with newer system python version. This should prevent (or at least detect earlier) issues like #68755 , #66346 or #66898 - or many other issues related to python version compatibility.
This is not ready for review yet, I'm exploring what issues are affecting CI environment, compared to my local deployment. This PR will likely end up including few more fixes for compatibility with Python 3.12.
What issues does this PR fix or reference?
Fixes
Previous Behavior
salt-ssh tested in very limited capacity, excluding managing modern distributions.
New Behavior
salt-ssh tested in broader set of environments, covering more of https://docs.saltproject.io/salt/install-guide/en/latest/topics/salt-supported-operating-systems.html#salt-supported-operating-systems
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes