[WIP] [3006.x] Initial re-do of changes for _sync_grains only affecting masterless minions#66737
Open
dmurphy18 wants to merge 2 commits intosaltstack:3006.xfrom
Open
[WIP] [3006.x] Initial re-do of changes for _sync_grains only affecting masterless minions#66737dmurphy18 wants to merge 2 commits intosaltstack:3006.xfrom
dmurphy18 wants to merge 2 commits intosaltstack:3006.xfrom
Conversation
This was referenced Jul 23, 2024
Closed
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Ensures that grains are sync'd before loading grains and then compiling pillar, since there could be custom grains used in pillar files, which will throw rendering errors if not found, when in masterless mode on a salt-minion
Rework of accidentally closed PR 65792
What issues does this PR fix or reference?
Fixes: #65027
Previous Behavior
Would throw rendering errors if custom grains in salt://_grains were used in pillar files, salt-minion in masterless mode.
New Behavior
No rendering errors thrown if custom grains in salt://_grains were used in pillar files, and custom grains values available in pillar, and salt-minion in masterless mode.
Additional tests to be written ensuring use with a salt-master is unaffected.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices, including the
PR Guidelines.
See GitHub's page on GPG signing for more information about signing commits with GPG.