[3006.x][wip] auto set gitbaase defaults#65310
Open
cmcmarrow wants to merge 1 commit intosaltstack:3006.xfrom
Open
[3006.x][wip] auto set gitbaase defaults#65310cmcmarrow wants to merge 1 commit intosaltstack:3006.xfrom
cmcmarrow wants to merge 1 commit intosaltstack:3006.xfrom
Conversation
cmcmarrow
requested review from
garethgreenaway
and removed request for
a team
salt-project-bot-prod-environment
bot
changed the title
Contributor
Author
|
TODO remove pre-commit upgrade, clean up init remote, fix pylint master |
twangboy
reviewed
Mar 25, 2025
Contributor
twangboy
left a comment
twangboy
left a comment
There was a problem hiding this comment.
It's probably gonna take some work to get this rebased. @dmurphy18 has done a lot of work in gitfs recently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
remove static args for gitfs
What issues does this PR fix or reference?
Fixes: #65096
Previous Behavior
Need it to provide static args for child classes
New Behavior
No static args and defaults dont lead to crash
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes