Skip to content

[fix] Records requests during iteration even though it is not serialized #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gustavocabral wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[fix] Records requests during iteration even though it is not serialized #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions addon-test-support/mock-provider/mirage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,13 @@ export default class MirageProvider extends MockProvider {
let { startMirage } = require(`${modulePrefix}/initializers/ember-cli-mirage`);
this.server = startMirage();
this.server.passthrough('/_pact/*path');

// Workaround for issue: https://github.com/salsify/ember-cli-pact/issues/32
const originalHandler = this.server.pretender.handledRequest;
this.server.pretender.handledRequest = (verb, path, request) => {
if (!this.interaction.captured) this.recordRequest(request);
return originalHandler(verb, path, request);
};
Copy link
Author

@gustavocabral gustavocabral Jan 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cc: @springerigor and @louiseavelar

Copy link
Author

@gustavocabral gustavocabral Jan 9, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not an ideal solution. However, it was inspired on:
https://github.com/salsify/ember-cli-pact/blob/master/addon-test-support/mock-provider/pretender.js#L31

} catch (error) {
throw new Error(`Unable to start mirage server; is ember-cli-mirage installed? ${error.message}`);
}
Expand All @@ -69,6 +76,7 @@ let mode = 'data';

export function PactEnabled(SerializerClass) {
return class PactEnabledSerializer extends SerializerClass {
// serialize will NOT be invoked if response's body is NOT serializable (e.g. empty body after DELETE request)
serialize(resource, request) {
let serialized = super.serialize(...arguments);
if (activeProvider) {
Expand Down