Open
Conversation
Collaborator
shivamgangwani
commented
Mar 28, 2023
shivamgangwani
commented
- Links were broken since loksabha's website domain was changed. We ran a batch check of about 1100 links across the dataset to confirm that the replacement link works (code for this has been included in case it needs to be done again in the future)
- The codebook mentions 'link' but it was not included in the downloaded file. Fixed that as well.
- Tested on local.
- This is a MacOS specific system file
To serve download files via nginx
Path patch
Path patch
- Now download files are served via nginx rather than being handled by the front end. - Added GZIP compression - Changed from CSV to TSV (Python had issues with reading the CSV text provided here, as the strings are very long, littered with quotation marks as well as commas, leading to issues with most parsers)
Test the links
Refer previous commit test link script was used to test the updated version of QH links update link read the ndjson files and updated the links and saved the data
refer previou commits Links updated
- Added 'link' to the downloaded file
- Added debug messages - Fixed the outpath
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.