Find version via hex_metadata.config instead of .hex#14
Open
kristoff3r wants to merge 1 commit intosaleyn:mainfrom
Open
Find version via hex_metadata.config instead of .hex#14kristoff3r wants to merge 1 commit intosaleyn:mainfrom
kristoff3r wants to merge 1 commit intosaleyn:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
.hexfile seem to be an outdated format, and it isn't present when building with Nix. You can easily get the same info using thehex_metadata.configfile instead, which is described in the standard here: https://github.com/hexpm/specifications/blob/main/package_metadata.md.I tested it locally by editing the
mix.exsfile in my deps folder and printing the version.I'll just add that I think reading files and invoking git from a
mix.exsas a library is bad practice, and I'd be happy to remove all of this logic as well if you want.