[xs][bugfix] quick return on not budgetExceeded or not grown#1
Open
sobolxxx wants to merge 2 commits intosalesp07:mainfrom
Open
[xs][bugfix] quick return on not budgetExceeded or not grown#1sobolxxx wants to merge 2 commits intosalesp07:mainfrom
sobolxxx wants to merge 2 commits intosalesp07:mainfrom
Conversation
I believe there should be || instead of && Rationale: we should not progress if the budget was not exceeded OR if last time was exceeded but it didn't grow since then
[xs][bugfix] quick return on not budgetExceeded or not grown
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe there should be || instead of &&
Rationale:
we should not progress if the budget was not exceeded OR if last time was exceeded but it didn't grow since then