feat: makes defineState to receive an object with exposed APIs#56
Closed
jodarove wants to merge 2 commits intosalesforce:mainfrom
Closed
feat: makes defineState to receive an object with exposed APIs#56jodarove wants to merge 2 commits intosalesforce:mainfrom
jodarove wants to merge 2 commits intosalesforce:mainfrom
Conversation
mburr-salesforce
approved these changes
Mar 28, 2025
divmain
approved these changes
Apr 2, 2025
| update: MakeUpdate, | ||
| fromContext: MakeContextHook<ContextShape>, | ||
| ) => (...args: Args) => InnerStateShape, | ||
| defineStateCallback: (api: ExposedAPIs<ContextShape>) => (...args: Args) => InnerStateShape, |
Contributor
There was a problem hiding this comment.
Does all the type inference continue to work with this change? I'm in favor so long as the types (internal and external) can still be inferred when writing & consuming a state manager.
Author
There was a problem hiding this comment.
yep, the type inference is working!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to improve the DX when defining a state manager.
Before this PR the
defineStatecallback receives a set of APIs as arguments, example:defineState((_atom, _computed, _update, fromContext) =>.... The main inconvenients are:fromContext)This PR targets those, by making the
defineStatecallback to receive a set of APIs in the form of an object, in that way the users could desctuct only those that will be used in the state manager:defineState(({ fromContext }) =>...🔴 This PR is a breaking change.
Note: the CI is failing with an error (seems to be unrelated to the changes as they pass in my local).