fix(state): unsub to subscribed context on disconnect#49
Merged
Conversation
c8fc5c2 to
d3593fb
Compare
rax-it
commented
Nov 7, 2024
divmain
requested changes
Nov 11, 2024
Contributor
Author
|
It seems we can't do
because then the template will look like: <template lwc:if={!hideChild}>which is also not allowed in lwc because of |
rax-it
commented
Nov 12, 2024
packages/@lwc/state/tsconfig.json
Outdated
| "moduleResolution": "nodeNext", | ||
| "esModuleInterop": false, | ||
| "target": "ES2021", | ||
| "target": "ES2023", |
Contributor
Author
There was a problem hiding this comment.
Required to use non-registered symbols as WeakMap keys, more details here
Contributor
Author
There was a problem hiding this comment.
reverted to es2021, as per our discussion
divmain
reviewed
Nov 12, 2024
Co-authored-by: Dale Bustad <dbustad@salesforce.com>
divmain
approved these changes
Nov 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.