Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ad8a34ac98
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| else if (!JsonNode.DeepEquals(existingServerObject, serverNode)) | ||
| { | ||
| servers["ai-code-graph"] = serverNode; | ||
| shouldWrite = true; |
There was a problem hiding this comment.
When .mcp.json already contains an ai-code-graph server object, any difference from the hardcoded template causes the entire object to be replaced, not merged. This will silently drop user-defined fields such as env, cwd, or wrapper-specific options, so rerunning setup-codex --db ... can break previously working Codex MCP setups that rely on those fields.
Useful? React with 👍 / 👎.
| if (!existing.Contains("Auto-Context: Code Graph Integration")) | ||
| { | ||
| File.AppendAllText(agentsPath, snippet); | ||
| created.Add(agentsPath + " (appended)"); |
There was a problem hiding this comment.
The AGENTS update check only looks for the section header and never validates the configured --db path inside that section, so rerunning setup-codex with a new database path leaves stale instructions in AGENTS.md. In that scenario, developers and agents are directed to the old DB path even though .mcp.json was updated, creating inconsistent integration behavior.
Useful? React with 👍 / 👎.
1 participant
No description provided.