Add Cursor MCP integration with context, hotspots, duplicates, and dr…#2
Add Cursor MCP integration with context, hotspots, duplicates, and dr…#2
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b3ef4429cb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (!servers.ContainsKey("ai-code-graph")) | ||
| { |
There was a problem hiding this comment.
Honor --db when ai-code-graph server already exists
When .cursor/mcp.json already contains an ai-code-graph entry, the command skips writing anything, so setup-cursor --db <path> cannot update the MCP server to the requested database path. This makes the --db option ineffective for reconfiguration (for example after moving graph.db), and Cursor will continue launching MCP against the stale path.
Useful? React with 👍 / 👎.
|
@codex re view again |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 299a396ec4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| else if (!JsonNode.DeepEquals(existingServerObject, serverNode)) | ||
| { | ||
| servers["ai-code-graph"] = serverNode; | ||
| shouldWrite = true; |
There was a problem hiding this comment.
Preserve existing MCP server fields during updates
When .cursor/mcp.json already contains an ai-code-graph server, any difference causes this code to replace the entire server object with a new minimal object (type, command, args). That drops user-defined fields such as env, cwd, or transport options, so running setup-cursor --db ... can silently break previously working MCP setups in projects that rely on those extra settings. Update logic should patch only the relevant fields (for example just args) instead of overwriting the full node.
Useful? React with 👍 / 👎.
…ift tools