Improve robot-indent so it works when c-basic-offset is 'set-from-style.#9
Open
j-oberlaender wants to merge 1 commit intosakari:masterfrom
Open
Improve robot-indent so it works when c-basic-offset is 'set-from-style.#9j-oberlaender wants to merge 1 commit intosakari:masterfrom
j-oberlaender wants to merge 1 commit intosakari:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I noticed that in my Emacs (24.3.1, cc-mode 5.33), the robot-indent function wouldn't work right because
c-basic-offsetreturns the symbol'set-from-style. I didn't find a fix anywhere that provided a proper solution to this issue, so I wrote one. The function still falls back to 4 spaces ifc-basic-offsetis unset, but tries its best to determine the currentc-default-style's offset in case'set-from-styleis used.If you're interested in the change, feel free to take it and run with it.