Fix bpf deadlock, which might occur when using DHCP#1
Open
stffabi wants to merge 1 commit intosaittam:masterfrom
Open
Fix bpf deadlock, which might occur when using DHCP#1stffabi wants to merge 1 commit intosaittam:masterfrom
stffabi wants to merge 1 commit intosaittam:masterfrom
Conversation
It seems like it's possible that during the processing of bpf_callback sometimes set_bpf_tap is called which then deadlocks BPF in the kernel. This manifests in different problems on the network stack and OSX can't even shutdown anymore because it can't unload the KEXT. set_bpf_tap is deprecated so we could get rid of it, but I don't know since what kernel version the new implementation is available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems like it's possible that during the processing of bpf_callback
sometimes set_bpf_tap is called which then deadlocks BPF
in the kernel.
This manifests in different problems on the network stack and OSX
can't even shutdown anymore because it can't unload the KEXT.
set_bpf_tap is deprecated so we could get rid of it, but I don't know
since what kernel version the new implementation is available.