Merged
Conversation
`fault_info` is conflict with the definition in vmlinux.h in arm64.
- Fix struct name collision: rename 'fault_info' to 'segfault_fault_info' to avoid conflict with kernel's fault_info struct in ARM64 vmlinux.h - Add VMA-based fallback symbol resolution for when processes exit before symbol resolution completes - Enhance both ConsoleProcessor and JsonProcessor with fallback methods - Provide meaningful binary+offset info even when /proc/<pid>/maps unavailable - Resolves CI compilation failure on ARM64 architecture
- Apply calculate_file_offset() to both resolve_address() and resolve_with_vma() - Convert VMA-based offsets from ExecMap::symbol() to proper file offsets - Ensures consistent, accurate offsets that match objdump/addr2line output - Affects both ConsoleProcessor and JsonProcessor symbol resolution - Extract filenames for cleaner output formatting Fixes issue where resolve_address() was using raw VMA offsets while resolve_with_vma() was correctly applying file offset calculation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed
Add a new tool
segfault-analyzerfor segmentation fault analysis.Fixes #44