Feat/disk dma driver #34
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -56,7 +56,7 @@ fn main() -> io::Result<()> { | |
| "targets/32bit_target.json", | ||
| "release", | ||
| ); | ||
| build_stage("../kernel", "targets/64bit_target.json", "release"); | ||
|
|
||
| // Combine binaries into one image | ||
| let input_dir = PathBuf::from("bin"); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| @echo off | ||
|
|
||
|
|
||
| qemu-system-x86_64 ^ | ||
| -M q35 ^ | ||
| -drive id=disk0,file=build/image.bin,if=none,format=raw ^ | ||
| -device ide-hd,drive=disk0,bus=ide.0,rotation_rate=1 ^ | ||
| -monitor stdio |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,9 @@ | ||||||||||||||||||||||||
| #!/bin/sh | ||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| qemu-system-x86_64 \ | ||||||||||||||||||||||||
| -M q35 \ | ||||||||||||||||||||||||
| -drive id=disk0,format=raw,file=build/image.bin,if=none \ | ||||||||||||||||||||||||
| -drive id=disk1,format=raw,file=build/bin/first_stage,if=none \ | ||||||||||||||||||||||||
| -device ide-hd,drive=disk0,bus=ide.0 \ | ||||||||||||||||||||||||
| -device ide-hd,drive=disk1,bus=ide.1 \ | ||||||||||||||||||||||||
| -monitor stdio | ||||||||||||||||||||||||
|
Comment on lines
3
to
9
There was a problem hiding this comment. ❓ Verification inconclusiveScript executed: cat -n build/runner/runner.shRepository: sagi21805/LearnixOS Repository: sagi21805/LearnixOS stdout: QEMU ahci controller ide-hd bus attachment disk Short answer: create an AHCI controller device, create a drive with if=none, then attach it with ide-hd on the controller's channel/bus. Example CLI (replace IMAGE with your file):
Notes:
References: QEMU ide-hd vs sata-hd ahci bus connection Short answer
Details and practical notes
Recommendation
References Wire the disk through an AHCI controller using the correct device type. Right now the VM attaches the disk via the legacy IDE bus ( qemu-system-x86_64 \
-M q35 \
+ -device ahci,id=ahci0 \
-drive id=disk0,format=raw,file=build/image.bin,if=none \
- -device ide-hd,drive=disk0,bus=ide.0 \
+ -device sata-hd,drive=disk0,bus=ahci0.0 \
-monitor stdioThe original suggestion to attach 📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,7 +13,12 @@ | |
| "position-independent-executables": true, | ||
| "relro-level": "off", | ||
| "stack-probes": { | ||
| "kind": "inline-or-call", | ||
| "min-llvm-version-for-inline": [ | ||
| 16, | ||
| 0, | ||
| 0 | ||
| ] | ||
| }, | ||
| "static-position-independent-executables": true, | ||
| "target-pointer-width": 64, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,5 +9,11 @@ cpu_utils = { path = "../shared/cpu_utils" } | |
| derive_more = { version = "2.0.1", default-features = false, features = [ | ||
| "full", | ||
| ] } | ||
| num_enum = { version = "0.7.5", default-features = false, features = [ | ||
| "complex-expressions", | ||
| ] } | ||
| extend = "1.2.0" | ||
| learnix-macros = { path = "../learnix-macros" } | ||
| strum_macros = { version = "0.27", default-features = false } | ||
| strum = { version = "0.27", default-features = false } | ||
| nonmax = { version = "0.5.5", default-features = false } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix typos in spell checker dictionary.
The spell checker dictionary contains misspellings:
Adding misspellings to the dictionary defeats the purpose of spell checking.
🔎 Proposed fix
Also applies to: 121-121
🤖 Prompt for AI Agents