Feat/disk dma driver #34

coderabbitai · 2025-12-24T14:52:32Z

⚠️ Potential issue | 🔴 Critical

Fix typos in spell checker dictionary.

The spell checker dictionary contains misspellings:

Line 42: "desciprtor" should be "descriptor"

Line 121: "purporse" should be "purpose"

Adding misspellings to the dictionary defeats the purpose of spell checking.

🔎 Proposed fix

- "desciprtor", + "descriptor",

- "purporse", + "purpose",

Also applies to: 121-121

🤖 Prompt for AI Agents

.vscode/settings.json around lines 42 and 121: the spell-check dictionary contains typos; replace "desciprtor" on line 42 with "descriptor" and replace "purporse" on line 121 with "purpose" so the dictionary only contains correctly spelled words.

coderabbitai · 2025-12-22T21:23:57Z

⚠️ Potential issue | 🟡 Minor

Remove trailing commas to ensure strict JSON compliance.

The static analysis tool flagged trailing commas before closing braces on lines 9, 13, 21, 25, 29, 35, 43, 51, 54, and 59. While Zed may support JSONC (which allows trailing commas), removing them ensures compatibility with strict JSON parsers.

🔎 Proposed fix

"minimap": { "display_in": "active_editor", - "show": "always", + "show": "always" }, "inlay_hints": { "show_background": true, - "enabled": true, + "enabled": true }, "indent_guides": { "coloring": "fixed", - "background_coloring": "disabled", + "background_coloring": "disabled" }, "features": { - "edit_prediction_provider": "zed", + "edit_prediction_provider": "zed" }, "telemetry": { "diagnostics": true, - "metrics": true, + "metrics": true }, "icon_theme": { "mode": "dark", "light": "Zed (Default)", - "dark": "Material Icon Theme", + "dark": "Material Icon Theme" }, "theme": { "mode": "dark", "light": "One Dark", - "dark": "One Dark Pro", + "dark": "One Dark Pro" }, "inlayHints": { "maxLength": null, "lifetimeElisionHints": { - "useParameterNames": true, + "useParameterNames": true }, "closureReturnTypeHints": { - "enable": "always", + "enable": "always" }, }, "check": { "command": "clippy", - "extraArgs": ["--release"], + "extraArgs": ["--release"] },

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

"minimap": {

"display_in": "active_editor",

"show": "always",

},

"inlay_hints": {

"show_background": true,

"enabled": true,

},

"relative_line_numbers": "enabled",

"show_edit_predictions": false,

"terminal": {},

"lsp_document_colors": "inlay",

"indent_guides": {

"coloring": "fixed",

"background_coloring": "disabled",

},

"colorize_brackets": true,

"features": {

"edit_prediction_provider": "zed",

},

"telemetry": {

"diagnostics": true,

"metrics": true,

},

"vim_mode": true,

"icon_theme": {

"mode": "dark",

"light": "Zed (Default)",

"dark": "Material Icon Theme",

},

"base_keymap": "VSCode",

"ui_font_size": 16,

"buffer_font_size": 15,

"theme": {

"mode": "dark",

"light": "One Dark",

"dark": "One Dark Pro",

},

"lsp": {

"rust-analyzer": {

"initialization_options": {

"cargo": {

"target": "x86_64-unknown-linux-none"

}

}

}

}

"inlayHints": {

"maxLength": null,

"lifetimeElisionHints": {

"useParameterNames": true,

},

"closureReturnTypeHints": {

"enable": "always",

},

},

"check": {

"command": "clippy",

"extraArgs": ["--release"],

},

},

},

},

"minimap": {

"display_in": "active_editor",

"show": "always"

},

"inlay_hints": {

"show_background": true,

"enabled": true

},

"relative_line_numbers": "enabled",

"show_edit_predictions": false,

"terminal": {},

"lsp_document_colors": "inlay",

"indent_guides": {

"coloring": "fixed",

"background_coloring": "disabled"

},

"colorize_brackets": true,

"features": {

"edit_prediction_provider": "zed"

},

"telemetry": {

"diagnostics": true,

"metrics": true

},

"vim_mode": true,

"icon_theme": {

"mode": "dark",

"light": "Zed (Default)",

"dark": "Material Icon Theme"

},

"base_keymap": "VSCode",

"ui_font_size": 16,

"buffer_font_size": 15,

"theme": {

"mode": "dark",

"light": "One Dark",

"dark": "One Dark Pro"

},

"lsp": {

"rust-analyzer": {

"initialization_options": {

"inlayHints": {

"maxLength": null,

"lifetimeElisionHints": {

"useParameterNames": true

},

"closureReturnTypeHints": {

"enable": "always"

}

},

"check": {

"command": "clippy",

"extraArgs": ["--release"]

}

}

}

}

🧰 Tools

🪛 Biome (2.1.2)

[error] 9-9: Expected a property but instead found '}'.

Expected a property here.

(parse)

[error] 13-13: Expected a property but instead found '}'.

Expected a property here.

(parse)

[error] 21-21: Expected a property but instead found '}'.

Expected a property here.

(parse)

[error] 25-25: Expected a property but instead found '}'.

Expected a property here.

(parse)

[error] 29-29: Expected a property but instead found '}'.

Expected a property here.

(parse)

[error] 35-35: Expected a property but instead found '}'.

Expected a property here.

(parse)

[error] 43-43: Expected a property but instead found '}'.

Expected a property here.

(parse)

[error] 51-51: Expected a property but instead found '}'.

Expected a property here.

(parse)

[error] 54-54: Expected a property but instead found '}'.

Expected a property here.

(parse)

[error] 55-55: Expected a property but instead found '}'.

Expected a property here.

(parse)

[error] 59-59: Expected a property but instead found '}'.

Expected a property here.

(parse)

[error] 60-60: Expected a property but instead found '}'.

Expected a property here.

(parse)

[error] 61-61: Expected a property but instead found '}'.

Expected a property here.

(parse)

[error] 62-62: Expected a property but instead found '}'.

Expected a property here.

(parse)

🤖 Prompt for AI Agents

In .zed/settings.json around lines 6 to 62, several object and property entries contain trailing commas (lines 9, 13, 21, 25, 29, 35, 43, 51, 54, 59) which violate strict JSON; remove each trailing comma before the corresponding closing brace or bracket so every object/array member list ends without a comma, then validate the file with a strict JSON linter or parser to ensure there are no remaining trailing commas or syntax errors.

coderabbitai · 2025-12-15T17:15:45Z

⚠️ Potential issue | 🟠 Major

❓ Verification inconclusive

Script executed:

cat -n build/runner/runner.sh

Repository: sagi21805/LearnixOS

Repository: sagi21805/LearnixOS
Exit code: 0

stdout:

1 #!/bin/sh 2 3 qemu-system-x86_64 \ 4 -M q35 \ 5 -drive id=disk0,format=raw,file=build/image.bin,if=none \ 6 -device ide-hd,drive=disk0,bus=ide.0 \ 7 -monitor stdio

QEMU ahci controller ide-hd bus attachment disk

Short answer: create an AHCI controller device, create a drive with if=none, then attach it with ide-hd on the controller's channel/bus. Example CLI (replace IMAGE with your file):

drive + controller + device example:
-drive id=disk,file=IMAGE,format=qcow2,if=none
-device ahci,id=ahci0,multifunction=on,bus=pci.0,addr=0x7
-device ide-hd,drive=disk,bus=ahci0.0,id=sata0

Notes:

Some docs/examples use "ahci.0" instead of "ahci0.0"; the bus name is based on the controller id you pass to -device (here id=ahci0). [1][2][3]

References:
[1] Gentoo Wiki / QEMU AHCI example (via StackOverflow).
[2] QEMU AHCI / -drive if=ahci discussion (qemu-devel mailing list).
[3] Example usage in proxmox/pve and patches showing -device ahci + ide-hd,bus=ahci0.0.

QEMU ide-hd vs sata-hd ahci bus connection

Short answer

ide-hd is the legacy IDE/PATA device model (master/slave semantics). sata-hd is the SATA device model intended for AHCI controllers. To get a real AHCI/SATA device on the AHCI controller use sata-hd (or attach a -drive to an AHCI controller). [1][2][3]

Details and practical notes

An AHCI port accepts one SATA device (ports 0..5); IDE buses accept two devices (master/slave). Mapping an if=ide/ide-hd onto an AHCI controller can cause confusing unit/bus re‑mapping or make QEMU/guest see the drive as legacy IDE. Q35/ahci behaviour has historically tried to map if=ide drives to AHCI ports (causing addressing/compatibility issues). Use sata-hd (or -device ahci,id=... plus -device sata-hd,bus=ahciX.N,drive=...) when you want a true AHCI/SATA attachment. [2][1][3]

Recommendation

For AHCI/SATA: create a -drive id=...,if=none,... then attach with -device sata-hd,drive=,bus=ahci0..

For legacy IDE (PIIX/PIIX3): use -device ide-hd (or -drive if=ide) attached to the IDE controller.

When using libvirt, be careful with libvirt’s bus/unit -> ahci port mapping (libvirt historically used unit as bus and needs correct bus/unit values). [3]

References
[1] QEMU-devel discussion on AHCI/IDE mapping and limitations.
[2] Patch/discussion explaining how -drive if=ide was mapped to AHCI on q35 (and master/slave vs single-port issues).
[3] QEMU/Xilinx wiki example showing attaching a disk to an AHCI controller with -device sata/ahci.

Wire the disk through an AHCI controller using the correct device type.

Right now the VM attaches the disk via the legacy IDE bus (-device ide-hd,drive=disk0,bus=ide.0), so your AHCI/DMA path may never be tested. To attach a disk to an AHCI controller, use -device sata-hd (not ide-hd, which is a legacy PATA device):

qemu-system-x86_64 \ -M q35 \ + -device ahci,id=ahci0 \ -drive id=disk0,format=raw,file=build/image.bin,if=none \ - -device ide-hd,drive=disk0,bus=ide.0 \ + -device sata-hd,drive=disk0,bus=ahci0.0 \ -monitor stdio

The original suggestion to attach ide-hd to an AHCI bus will not properly exercise the AHCI driver; sata-hd is the correct device model for AHCI attachment.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

qemu-system-x86_64 \

-M q35 \

-drive id=disk0,format=raw,file=build/image.bin,if=none \

-device ide-hd,drive=disk0,bus=ide.0 \

-monitor stdio

qemu-system-x86_64 \

-M q35 \

-device ahci,id=ahci0 \

-drive id=disk0,format=raw,file=build/image.bin,if=none \

-device sata-hd,drive=disk0,bus=ahci0.0 \

-monitor stdio

🤖 Prompt for AI Agents

In build/runner/runner.sh around lines 3 to 7 the disk is attached as a legacy IDE device (ide-hd) so the AHCI/DMA path won’t be exercised; replace the IDE setup with an AHCI controller and attach the disk using the correct SATA device model (create an AHCI controller, e.g. -device ahci,id=ahci and attach the drive with -device sata-hd,drive=disk0,bus=ahci.0) so the VM uses the AHCI path instead of legacy PATA.

-Original file line number
+Diff line change
@@ Expand Up / @@ -4,3 +4,12 @@ build-std-features = ["compiler-builtins-mem"] @@
     unstable-options = true
     [build]
     rustflags = ["-Zpolonius"]
+    [target.'cfg(target_os = "windows")']
+    runner = ".\\build\\runner\\runner.bat"
+    [target.'cfg(target_os = "macos")']
+    runner = ["sh", "./build/runner/runner.sh"]
+    [target.'cfg(target_os = "linux")']
+    runner = ["sh", "./build/runner/runner.sh"]

-Original file line number
+Diff line change
@@ Expand Up / @@ -9,51 +9,180 @@ @@
         ],
         "rust-analyzer.cargo.target": "x86_64-unknown-linux-gnu",
         "cSpell.words": [
+            "abar",
+            "acmd",
+            "ACPI",
             "ACPINVS",
+            "adse",
+            "AHCI",
+            "alhd",
+            "alpe",
             "APIC",
+            "apst",
+            "apste",
             "avavilable",
             "BIST",
+            "BOHC",
             "bootable",
             "capslock",
             "cardbus",
+            "cccs",
+            "cfis",
+            "clbu",
+            "CLFSH",
+            "CMOV",
+            "CNXT",
+            "colorcode",
+            "cpde",
+            "cpds",
             "Cpuid",
+            "ctba",
+            "ctbau",
+            "dbau",
+            "desciprtor",
+            "deto",
             "devsel",
+            "devslp",
+            "dhre",
+            "dhrs",
+            "dlae",
+            "dmpe",
+            "dmps",
+            "DPIO",
+            "dsfis",
+            "DTES",
+            "dwords",
             "EFER",
+            "EHCI",
+            "EISA",
+            "fbscp",
+            "fbss",
+            "FDDI",
+            "firewire",
+            "freelist",
+            "FXSR",
+            "Gameport",
+            "GPIB",
+            "hbde",
+            "hbds",
+            "hbfe",
+            "hbfs",
+            "Hotplug",
+            "hpcp",
+            "HPET",
+            "ilog",
+            "infe",
+            "infs",
             "inval",
             "iopl",
+            "ipme",
+            "IPMIPI",
+            "ipms",
+            "IRDA",
+            "ISDN",
+            "kfree",
+            "kmalloc",
             "lctrl",
             "Learnix",
             "lgdt",
             "ljmp",
             "lshift",
+            "mdat",
+            "metavar",
+            "mmap",
+            "MOVBE",
+            "mpsp",
+            "mpss",
+            "mrsm",
+            "MTRR",
+            "Multiport",
             "nomem",
+            "nonmax",
             "nostack",
+            "notif",
+            "NVME",
+            "NVMHCI",
+            "nvmp",
+            "OHCI",
             "okprintln",
+            "OSXSAVE",
             "outb",
             "outl",
+            "PCID",
+            "PCLMUL",
+            "PDCM",
             "PDPT",
+            "peekable",
+            "PICMG",
+            "PICPI",
+            "PIIX",
+            "POPCNT",
             "popfq",
+            "prce",
+            "prcs",
+            "prdb",
+            "Prdt",
+            "prdtl",
             "prefetchable",
+            "psfis",
+            "purporse",
             "pushfq",
             "rdmsr",
+            "RDRAND",
+            "realtek",
             "repr",
+            "rfis",
             "rflags",
             "rodata",
             "rshift",
+            "RTCPI",
             "rustc",
+            "sact",
+            "sadm",
+            "safte",
+            "salp",
             "scancode",
+            "sctl",
+            "sdbe",
+            "sdbfis",
+            "SDBG",
+            "sdbs",
+            "SERCOS",
             "serr",
+            "sgpio",
             "SMAP",
+            "SMIC",
+            "smps",
+            "snqc",
+            "sntf",
             "sofware",
+            "sooe",
+            "ssntf",
+            "SSSE",
+            "ssts",
             "superkey",
+            "tfee",
+            "tfes",
             "thiserror",
+            "udma",
+            "ufis",
+            "UHCI",
+            "Unassignment",
             "Uninit",
+            "USBPI",
             "virt",
+            "virtio",
             "wrmsr",
-            "xchg"
+            "xchg",
+            "XHCI",
+            "XSAVE",
+            "XTPR"
         ],
-        "rust-analyzer.inlayHints.chainingHints.enable": false,
+        "rust-analyzer.inlayHints.chainingHints.enable": true,
         "rust-analyzer.check.command": "clippy",
+        "rust-analyzer.check.extraArgs": [
+            "--release"
+        ],
         "rust-analyzer.cargo.extraEnv": {
             "RUSTFLAGS": "-Zpolonius"
         },
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up / @@ -56,7 +56,7 @@ fn main() -> io::Result<()> { @@
             "targets/32bit_target.json",
             "release",
         );
-        build_stage("../kernel", "targets/64bit_target.json", &profile);
+        build_stage("../kernel", "targets/64bit_target.json", "release");
         // Combine binaries into one image
         let input_dir = PathBuf::from("bin");
@@ Expand Down @@

-Original file line number
+Diff line change
@@ -0,0 +1,8 @@
+    @echo off
+    qemu-system-x86_64 ^
+        -M q35 ^
+        -drive id=disk0,file=build/image.bin,if=none,format=raw ^
+        -device ide-hd,drive=disk0,bus=ide.0,rotation_rate=1 ^
+        -monitor stdio

-Original file line number
+Diff line change
@@ Expand Up / @@ -13,7 +13,12 @@ @@
       "position-independent-executables": true,
       "relro-level": "off",
       "stack-probes": {
-        "kind": "call"
+        "kind": "inline-or-call",
+        "min-llvm-version-for-inline": [
+,
+,
+        ]
       },
       "static-position-independent-executables": true,
       "target-pointer-width": 64,
@@ Expand Down @@

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Feat/disk dma driver #34

Uh oh!

Diff view

Diff view

There are no files selected for viewing

coderabbitai bot Dec 24, 2025

Uh oh!

coderabbitai bot Dec 22, 2025

Uh oh!

coderabbitai bot Dec 15, 2025

Uh oh!

Uh oh!

-Original file line number
+Diff line change
@@ Expand Up / @@ -9,5 +9,11 @@ cpu_utils = { path = "../shared/cpu_utils" } @@
     derive_more = { version = "2.0.1", default-features = false, features = [
         "full",
     ] }
+    num_enum = { version = "0.7.5", default-features = false, features = [
+        "complex-expressions",
+    ] }
     extend = "1.2.0"
     learnix-macros = { path = "../learnix-macros" }
+    strum_macros = { version = "0.27", default-features = false }
+    strum = { version = "0.27", default-features = false }
+    nonmax = { version = "0.5.5", default-features = false }

Uh oh!

Feat/disk dma driver #34

Uh oh!

Feat/disk dma driver #34

Uh oh!

Uh oh!

Diff view

Diff view

There are no files selected for viewing

coderabbitai bot Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!