src/sage/rings: remove block-level "needs sage.foo" tags#41689
src/sage/rings: remove block-level "needs sage.foo" tags#41689orlitzky wants to merge 6 commits intosagemath:developfrom
Conversation
|
Documentation preview for this PR (built with commit 21be073; changes) is ready! 🎉 |
orlitzky
force-pushed
the
remove-rings-block-needs-sage-tags
branch
from
9cd7d45 to
73d8488
Compare
dcoudert
left a comment
dcoudert
left a comment
There was a problem hiding this comment.
Please fix the warnings raised by the CIs
| Here is another example with an equation of degree `2`:: | ||
|
|
||
| sage: # needs sage.libs.flint | ||
| sage: b = R.unknown() |
There was a problem hiding this comment.
Warning : Variable 'R' referenced here was set only in doctest marked '# needs sage.libs.flint'
|
|
||
| sage: # needs sage.modules | ||
| sage: c = LazyCombinatorialSpecies(QQ, "X").Cycles().cycle_index_series() | ||
| sage: Lplus = L(lambda n: p([1]*n), valuation=1) |
There was a problem hiding this comment.
other warnings since variable L was set in a doctest marked '# needs sage.modules'
|
|
||
| sage: # needs sage.libs.pari | ||
| sage: phi = R.hom([5]) | ||
| sage: L._is_valid_homomorphism_(ZZ, [3], base_map=phi) |
There was a problem hiding this comment.
Warning: Variable 'L' referenced here was set only in doctest marked '# needs sage.libs.pari'
|
Sorry, I did try to address this after you pointed it out on the other PR. Github is only showing 50 warnings (max) at a time, and each warning is triggered 10x for each CI system, so more of them keep popping up as I fix others. |
These are just line noise at this point. No one is maintaining them, and there's no way to install Sage without these components.
These aren't block tags, but the block tags I removed use variables that are declared behind these.
To avoid warnings about variables declared behind them.
orlitzky
force-pushed
the
remove-rings-block-needs-sage-tags
branch
from
e67b0bc to
4d4675f
Compare
| Of course, standard operations are supported:: | ||
|
|
||
| sage: # needs sage.libs.flint | ||
| sage: b = R(42/17) |
There was a problem hiding this comment.
apparently here too
Variable 'R' referenced here was set only in doctest marked '# needs sage.libs.flint'
|
With any luck that should be all of them, since we were < 50 to begin with. Next time I'll leave the PR as a draft until I'm sure all the warnings are gone. |
These keep showing up as CI warnings.
|
Somehow, more showed up, in files the last commit did not touch 🤷 |
3 participants
These are just line noise at this point. No one is maintaining them, and there's no way to install Sage without these components.
The tags eventually need to be removed if we are to stop detecting the "features" over and over again while testing.
The
needs sage.libs.giacandneeds sage.rings.polynomial.pboritags were left alone because giac and brial (was: pbori) are actually optional.