refactor: Remove unused contract address fields from chain config#1516
Open
refactor: Remove unused contract address fields from chain config#1516
Conversation
These 9 contract address fields were added in July 2024 but never populated with data. They appear empty on staging and production, adding noise to the API response without serving any purpose. Closes PLA-1142 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Pull Request Test Coverage Report for Build 23534977119Details
💛 - Coveralls |
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
@Zalens do we also need a PR on the client-gateway? The chain object there has those fields as well. |
Member
Author
Good point, I'll check |
Zalens
added a commit
to safe-global/safe-client-gateway
that referenced
this pull request
Mar 25, 2026
Remove ContractAddressesSchema, domain entity, route DTO, test builder, and all references to contractAddresses from chain objects. These fields were never populated in the config service and are being removed there as well (safe-global/safe-config-service#1516). Closes PLA-1142 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
3 tasks
Member
Author
|
@compojoom PR is here: safe-global/safe-client-gateway#2990 |
Contributor
|
@claude review |
|
Claude finished @PooyaRaki's task —— View job Review
Looks good. Clean removal across model, serializer, factory, and tests. The migration is correct and the dependency chain is proper ( One minor note:
No issues found. Approve. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
safeSingletonAddress,safeProxyFactoryAddress,multiSendAddress,multiSendCallOnlyAddress,fallbackHandlerAddress,signMessageLibAddress,createCallAddress,simulateTxAccessorAddress,safeWebAuthnSignerFactoryAddress) from the Chain model and API responseContractAddressesSerializer, model fields, test factory assignments, and test expectationsCloses PLA-1142
Test plan
contractAddresses🤖 Generated with Claude Code