Add sound effects after checking the guess#30
Open
brookegreenstein wants to merge 3 commits intosabrina-aip:mainfrom
Open
Add sound effects after checking the guess#30brookegreenstein wants to merge 3 commits intosabrina-aip:mainfrom
brookegreenstein wants to merge 3 commits intosabrina-aip:mainfrom
Conversation
…hey spelled the word right or wrong
brookegreenstein
changed the title
jasger9000
suggested changes
Feb 2, 2024
Contributor
jasger9000
left a comment
jasger9000
left a comment
There was a problem hiding this comment.
Please exclude your .DS_STORE files, we don't really need to know your layout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a correct "ding" type sound for when the word is spelled correctly and a "wrong buzzer" type sound for when the word is spelled incorrectly.
I thought it would be nice to add sounds to give the user audio feedback about whether they spelled the word right or wrong, since you're already paying a lot of attention to the audio as you're thinking about and spelling the word. Gotta increase the dopamine and keep them coming back to spell more words!
Both sounds were downloaded from https://pixabay.com/sound-effects/ which says they are royalty-free to download and use and don't need to be credited. The sound effects were named "Correct-2" and "Wrong".