プラン設定機能追加 #3

SasakiTakatsugu · 2025-10-02T00:46:09Z

No description provided.

Copilot

Pull Request Overview

This PR implements plan management functionality by replacing centralized error handling with local error handling and adding new API endpoints for plan operations.

Removed the centralized HandleApiException method from helper classes across both .NET 8 and .NET Framework 4.8 projects
Replaced all API exception handling with local error handling using standardized error messages and logging
Added new API endpoints for pricing plans, tax rates, and tenant plan management

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
SampleWebAppDotNet8/Program.cs	Replaced centralized exception handling with local error handling and console logging
SampleWebAppDotNet8/Helpers/SaasusApiHelpers.cs	Removed HandleApiException methods
SampleWebAppDotNet8/Controllers/BillingController.cs	Added new pricing plan endpoints and replaced exception handling
SampleWebAppDotNet48/Helpers/SaasusApiHelpers.cs	Updated error response format from "error" to "detail" property
SampleWebAppDotNet48/Controllers/MainController.cs	Replaced centralized exception handling with local error handling
SampleWebAppDotNet48/Controllers/BillingController.cs	Added new pricing plan endpoints and replaced exception handling

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-02T00:47:34Z

SampleWebAppDotNet48/Controllers/BillingController.cs

-                var handled = SaasusApiHelpers.HandleApiException(ex);
-                return Content(handled.Item1, handled.Item2);
+                System.Diagnostics.Debug.WriteLine($"Failed to update metering count now: {ex.Message}");
+                return Content(HttpStatusCode.InternalServerError, new { error = "Failed to update metering count" });


The error message 'Failed to update metering count' doesn't match the method name 'UpdateMeteringCountNow'. It should be 'Failed to update metering count now' to be consistent with the method purpose.

Suggested change

return Content(HttpStatusCode.InternalServerError, new { error = "Failed to update metering count" });

return Content(HttpStatusCode.InternalServerError, new { error = "Failed to update metering count now" });

Copilot · 2025-10-02T00:47:35Z

SampleWebAppDotNet8/Controllers/BillingController.cs

@@ -1,4 +1,6 @@
 using Microsoft.AspNetCore.Mvc;
+using Newtonsoft.Json;


Both Newtonsoft.Json and System.Text.Json.Serialization are imported, but only System.Text.Json.Serialization attributes are used in the code. Remove the unused Newtonsoft.Json import.

Suggested change

using Newtonsoft.Json;

SDKのモデルをJSON化する際にNewtonsoft.Jsonが必要

Copilot · 2025-10-02T00:47:35Z

SampleWebAppDotNet8/Controllers/BillingController.cs

+        var jsonResponse = JsonConvert.SerializeObject(plans.VarPricingPlans);
+        return Content(jsonResponse, "application/json");


Using Newtonsoft.Json's JsonConvert.SerializeObject is inconsistent with the System.Text.Json attributes used elsewhere. Consider using the built-in JSON serialization or return Ok() directly instead of manual serialization.

SDKのモデルをJSON化する際にNewtonsoft.Jsonが必要

Copilot · 2025-10-02T00:47:35Z

SampleWebAppDotNet8/Controllers/BillingController.cs

+        var jsonResponse = JsonConvert.SerializeObject(taxRates.VarTaxRates);
+        return Content(jsonResponse, "application/json");


Same inconsistency as above - using Newtonsoft.Json serialization with System.Text.Json attributes. Consider using Ok() to return the object directly for consistent JSON serialization.

Suggested change

var jsonResponse = JsonConvert.SerializeObject(taxRates.VarTaxRates);

return Content(jsonResponse, "application/json");

return Ok(taxRates.VarTaxRates);

SDKのモデルをJSON化する際にNewtonsoft.Jsonが必要

SasakiTakatsugu · 2025-10-02T00:52:45Z

同機能修正

フロント
saasus-platform/implementation-sample-front-react#19

バックエンド
#3
saasus-platform/implementation-sample-api-php#7
saasus-platform/implementation-sample-api-javascript#7
saasus-platform/implementation-sample-api-python#26
saasus-platform/implementation-sample-api-go#10

javaのみ未着手

Copilot

Pull Request Overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-23T03:26:06Z

SampleWebAppDotNet8/Controllers/BillingController.cs

@@ -1,4 +1,6 @@
 using Microsoft.AspNetCore.Mvc;
+using Newtonsoft.Json;


Two different JSON serialization libraries are imported. Line 2 imports Newtonsoft.Json (used at line 644) and line 3 imports System.Text.Json.Serialization (used at line 839). This creates an inconsistent approach to JSON handling. Consider standardizing on one library throughout the codebase.

Suggested change

using Newtonsoft.Json;

Copilot · 2025-10-23T03:26:06Z

SampleWebAppDotNet8/Controllers/BillingController.cs

+        var jsonResponse = JsonConvert.SerializeObject(plans.VarPricingPlans);
+        return Content(jsonResponse, "application/json");


Manually serializing to JSON and returning Content() bypasses ASP.NET Core's built-in content negotiation and serialization. Consider returning Ok(plans.VarPricingPlans) directly, which is consistent with other endpoints in this controller (e.g., lines 749, 810) and leverages the framework's serialization.

Suggested change

var jsonResponse = JsonConvert.SerializeObject(plans.VarPricingPlans);

return Content(jsonResponse, "application/json");

return Ok(plans.VarPricingPlans);

Copilot · 2025-10-23T03:26:06Z

SampleWebAppDotNet8/Controllers/BillingController.cs

+        var jsonResponse = JsonConvert.SerializeObject(taxRates.VarTaxRates);
+        return Content(jsonResponse, "application/json");


Manually serializing to JSON and returning Content() bypasses ASP.NET Core's built-in content negotiation and serialization. Consider returning Ok(taxRates.VarTaxRates) directly, which is consistent with other endpoints in this controller and leverages the framework's serialization.

Suggested change

var jsonResponse = JsonConvert.SerializeObject(taxRates.VarTaxRates);

return Content(jsonResponse, "application/json");

return Ok(taxRates.VarTaxRates);

Copilot · 2025-10-23T03:26:07Z

SampleWebAppDotNet8/Controllers/BillingController.cs

+      catch (Exception ex)
+      {
+        _logger.LogError(ex, "Failed to get pricing plans");
+        return StatusCode(500, new { detail = "Internal server error" });


The error message 'Internal server error' is generic and doesn't help identify the issue. Other error handlers in this file use descriptive messages like 'Failed to get pricing plans'. Consider using 'Failed to get pricing plans' for consistency with the logging statement at line 649.

Suggested change

return StatusCode(500, new { detail = "Internal server error" });

return StatusCode(500, new { detail = "Failed to get pricing plans" });

Copilot · 2025-10-23T03:26:07Z

SampleWebAppDotNet8/Controllers/BillingController.cs

+      catch (Exception ex)
+      {
+        _logger.LogError(ex, "Failed to get tax rates");
+        return StatusCode(500, new { detail = "Internal server error" });


The error message 'Internal server error' is generic and doesn't help identify the issue. Other error handlers in this file use descriptive messages like 'Failed to get tax rates'. Consider using 'Failed to get tax rates' for consistency with the logging statement at line 681.

Suggested change

return StatusCode(500, new { detail = "Internal server error" });

return StatusCode(500, new { detail = "Failed to get tax rates" });

add-plan-setting-page

ed7feaa

SasakiTakatsugu requested review from KooriyamaHiroki, bigdragon0610 and silent-bayline October 2, 2025 00:46

SasakiTakatsugu self-assigned this Oct 2, 2025

SasakiTakatsugu requested a review from Copilot October 2, 2025 00:46

Copilot AI reviewed Oct 2, 2025

View reviewed changes

SasakiTakatsugu mentioned this pull request Oct 2, 2025

プラン設定機能追加 saasus-platform/implementation-sample-front-react#19

Merged

Fix error message in UpdateMeteringCountNow method

0c016b8

SasakiTakatsugu mentioned this pull request Oct 7, 2025

プラン設定変更の実装ガイドを追加 Anti-Pattern-Inc/saasus-platform-document#233

Merged

1 task

KooriyamaHiroki requested a review from Copilot October 23, 2025 03:25

Copilot AI reviewed Oct 23, 2025

View reviewed changes

KooriyamaHiroki approved these changes Oct 23, 2025

View reviewed changes

KooriyamaHiroki merged commit eac3c62 into main Oct 23, 2025

	return Content(HttpStatusCode.InternalServerError, new { error = "Failed to update metering count" });
	return Content(HttpStatusCode.InternalServerError, new { error = "Failed to update metering count now" });

		@@ -1,4 +1,6 @@
		using Microsoft.AspNetCore.Mvc;
		using Newtonsoft.Json;

		var jsonResponse = JsonConvert.SerializeObject(plans.VarPricingPlans);
		return Content(jsonResponse, "application/json");

	var jsonResponse = JsonConvert.SerializeObject(taxRates.VarTaxRates);
	return Content(jsonResponse, "application/json");
	return Ok(taxRates.VarTaxRates);

	var jsonResponse = JsonConvert.SerializeObject(plans.VarPricingPlans);
	return Content(jsonResponse, "application/json");
	return Ok(plans.VarPricingPlans);

	return StatusCode(500, new { detail = "Internal server error" });
	return StatusCode(500, new { detail = "Failed to get pricing plans" });

プラン設定機能追加 #3

プラン設定機能追加 #3

Uh oh!

Conversation

SasakiTakatsugu commented Oct 2, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

SasakiTakatsugu Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

SasakiTakatsugu Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

SasakiTakatsugu Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

SasakiTakatsugu commented Oct 2, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants