Tf idf #13
Open
Tf idf #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elena-NSU
reviewed
May 27, 2021
tfidf_1.py
Outdated
| for item in _tf_txt: | ||
| tf.append((item, _tf_txt[item] / len(text))) | ||
|
|
||
| if os.path.isfile('idf.json'): |
Collaborator
There was a problem hiding this comment.
у тебя получается, что для каждого входного текста ты либо считаешь, либо загружаешь файл с idf - почему это не сделать один раз в конструкторе?
Elena-NSU
reviewed
May 28, 2021
Elena-NSU
reviewed
May 28, 2021
Elena-NSU
reviewed
May 28, 2021
tfidf_1.py
Outdated
| sent.append(source.text) | ||
| for i in sent: | ||
| self._texts.append(re.sub(r'[^\w\s]', '', i.lower())) | ||
| if os.path.exists('idf_file'): |
Collaborator
There was a problem hiding this comment.
а почему на существование проверяется файл с одним названием, а загружается информация из другого? это же должен быть всё один файл?
Owner
Author
There was a problem hiding this comment.
Ой, это я опечаталась
Collaborator
There was a problem hiding this comment.
должен быть 'idf_file.json' судя по коду ниже. но уже ладно, зачтено задание:)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.