Skip to content

chore: migrate submodule from protos to s2-specs #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cristi- wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: migrate submodule from protos to s2-specs #106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .gitmodules
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
[submodule "protos"]
path = protos
url = https://github.com/s2-streamstore/s2-protos.git
[submodule "s2-specs"]
path = s2-specs
url = https://github.com/s2-streamstore/s2-specs.git
0 protos → s2-specs
Open in desktop
Submodule s2-specs updated from 000000 to 8babbd
2 changes: 1 addition & 1 deletion update_protos
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
set -euo pipefail

cd src/streamstore/_lib
uv run python -m grpc_tools.protoc -I../../../protos --python_out=. --pyi_out=. --grpc_python_out=. ../../../protos/s2/v1alpha/s2.proto
uv run python -m grpc_tools.protoc -I../../../s2-specs --python_out=. --pyi_out=. --grpc_python_out=. ../../../s2-specs/s2/v1alpha/s2.proto
# workaround for https://github.com/protocolbuffers/protobuf/issues/7061
find . -name '*.py' | xargs -I{} sed -i '' 's/from s2\.\(v[0-9][a-z0-9]*\) import s2_pb2 as s2_dot_\1_dot_s2__pb2/from streamstore._lib.s2.\1 import s2_pb2 as s2_dot_\1_dot_s2__pb2/' {}
uv run poe checker