Feat: add xbox controller eject button mapping to take screenshot #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR remaps the Xbox Series X/S wireless controller's share button (key 167) from BACK to SYSRQ to enable screenshot functionality on Android. The change aligns with the button's intended use on Steam and Xbox platforms, where the share button is primarily used for taking screenshots.
- Changed key 167 mapping from
BACKtoSYSRQfor screenshot functionality - Updated inline comment to reflect the new purpose and behavior
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| key 315 BUTTON_START # center right button with "hamburger" icon. Normally: BUTTON_START | ||
| key 316 BUTTON_MODE # big Xbox logo center top button. Normally: BUTTON_MODE | ||
| key 167 BACK # center bottom button with an "eject" icon. Normally: ??? | ||
| key 167 SYSRQ # center bottom button with an "eject" icon. Normally: takescreenshot (PRINT_SCREEN) |
There was a problem hiding this comment.
The word "takescreenshot" should be "take screenshot" (two words) for proper grammar and readability.
Suggested change
| key 167 SYSRQ # center bottom button with an "eject" icon. Normally: takescreenshot (PRINT_SCREEN) | |
| key 167 SYSRQ # center bottom button with an "eject" icon. Normally: take screenshot (PRINT_SCREEN) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR change a mapping on xbox controller with share button.
Whats problem
Origin maping is
BACK, but in android, we could use button b to back, so this mapping is wasting.Refer to Steam and Xbox use case, which is alway used for taking screenshot and sharing. So I changed to
SYSRQ, which would run screenshot default on android.I've test on my phone(Oneplus, ColorOS 15, Android 15). Please considered merge if it's help you as well.