Conversation
yuuu
reviewed
Aug 4, 2025
|
|
||
| puts 'bugカフェへようこそ！ご注文は？ 番号でどうぞ' | ||
| order1 = take_order(DRINKS) | ||
| drink_order_number = take_order(DRINKS) |
There was a problem hiding this comment.
この変数の見直しができているのは素晴らしいですね ✨
今後同じようなミスが起こることを防げるはずです。
cafe.rb
Outdated
| food_order_number = take_order(FOODS) | ||
|
|
||
| total = FOODS[order1][:price] + DRINKS[order2][:price] | ||
| total = FOODS[food_order_number][:price].to_i + DRINKS[drink_order_number][:price].to_i |
There was a problem hiding this comment.
確かにここで .to_i すればバグは解消されるのですが、今回の場合 price を文字列として宣言する必要がないので、宣言の時点で数値とするようにしましょう。
Owner
Author
There was a problem hiding this comment.
会計額異様に高くなるバグの根本原因を修正にて反映しました
根本原因に目が向いていませんでした(;'∀')
レビューありがとうございます！
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
以下四つのバグを修正しました。