Make _parse_periphs() gawk case insensitive #252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some devices have an unexpected PCI class so the original XSOS_LSPCI_*_REGEX will miss them. We relax the pattern matching by making it case insensitive and removing the colon. Fixes: ryran#10 Signed-off-by: Patrick Talbert <ptalbert@redhat.com>
Collaborator
Author
|
If this is taken then for consistency's sake we should also remove the colon from the other XSOS_LSPCI_*_REGEX definitions. |
Collaborator
|
This doesn't break anything in my tests against VM sosreports, so looks good to me. Did you want to push the same change to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some devices have an unexpected PCI class so the original XSOS_LSPCI_*_REGEX
will miss them.
We relax the pattern matching by making it case insensitive and removing the
colon.
Fixes: #10
Signed-off-by: Patrick Talbert ptalbert@redhat.com