fix(karaoke): show next lyric during center-mode interlude dots#1029
Draft
fix(karaoke): show next lyric during center-mode interlude dots#1029
Conversation
Center alignment previously replaced the visible list with only the interlude placeholder, hiding the upcoming line until playback reached it. Return placeholder + next line so the next lyric appears immediately (dimmed) while dots run. Co-authored-by: Ryo Lu <me@ryo.lu>
|
The preview deployment for ryos-dev is ready. 🟢 Open Preview | Open Build Logs | Open Application Logs Last updated at: 2026-04-04 05:22:55 CET |
… dots - applyKaraokeInterludeAlternating long gap returns [next, next+1] (no previous row) - getGapInterludeInlineLead mirrors placeholder timing for inline dots on upcoming line - LyricsDisplay wires gap lead when row matches next lyric after current index Co-authored-by: Ryo Lu <me@ryo.lu>
- Return [next+1, next] so layout matches pre-interlude [current, next] - During gap interlude treat upcoming line as non-current; position by index Co-authored-by: Ryo Lu <me@ryo.lu>
Delayed setAltLines left visibleLines input stale vs findCurrentLineIndex, so interlude preview did not track through next+1 as time advanced. Co-authored-by: Ryo Lu <me@ryo.lu>
Remove parity-based [next,current] swap so line slots do not flip when the active line index changes during playback. Co-authored-by: Ryo Lu <me@ryo.lu>
- Add isAlternatingInterludeDotsActive (intro/gap + ellipsis enabled) - Normal alternating playback keeps stable [current, next] rows - Restore original parity swap for altLines during ●●● segments only Co-authored-by: Ryo Lu <me@ryo.lu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[next+1, next]with inline dots on upcoming line; upcoming stays bottom slot.altLinesnow updates immediately whenactualCurrentLinechanges (removed delayedsetTimeout). StalealtLineshad causedapplyKaraokeInterludeEllipsisto receive the wrong[current, next]pair whilefindCurrentLineIndexhad already advanced — interlude / preview did not follow playback through the next+1 window.Testing
bun test tests/test-karaoke-interlude-display.test.ts(existing)bun run build