feat: protect admin routes with optional basic auth#164
Closed
davetha wants to merge 6 commits intorynfar:mainfrom
Closed
feat: protect admin routes with optional basic auth#164davetha wants to merge 6 commits intorynfar:mainfrom
davetha wants to merge 6 commits intorynfar:mainfrom
Conversation
Author
|
Superseded by a new PR that includes a health check fix for multi-profile Docker setups. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/health,/telemetry, and/telemetry/*Use Case
My goal is to run one Meridian instance for multiple machines and access it over my private network or Tailscale. In that setup, I still want tighter control over who can see
/healthand/telemetry, not just who can call/v1/messages.Basic Auth helps for browser access, while admin API keys still work for scripts and tooling.
Dependency
Draft because this currently stacks on top of:
GitHub cannot express the exact stacked base across forks, so this draft PR includes earlier work until the lower PRs merge.
Testing
bun test src/__tests__/proxy-admin-auth.test.ts src/__tests__/proxy-auth.test.ts src/__tests__/configLoader.test.tsnpm run build